User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Fill the wasted space in the System module on Home Dashboard, by default, with 4 boxes and not just 3 by introducing the System Information quick icon (after all, this is the SYSTEM module of quick icons!)
See Home Dashboard - toggle the new icon on/off
A Missed opportunity of space
By default, on new installation, there are now 4 icons in the System box on Home Dashboard.
There is a new option that can be toggled on the edit screen:
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings Modules SQL Installation Postgresql |
Labels |
Added:
?
?
|
@PhilETaylor You should change also the params for the quickicon in the 4.0.0-2019-07-13.sql
script so they are created in the right way when updating from 3.10-dev:
The params there should be exactly the same as in the base.sql for the same module.
But as I can see the params are outdated there also for other quickicons, e.g. "header_icon" values differ to a new installation.
So maybe I have to make a separate PR for that if you don't want to clean that up here.
Ive turned a complete blind eye to 3.10
on purpose in my life :) If you are going to be cleaning those up anyway, and if this gets merged then please add this for me :) Thank You.
The next question is if something to be done for updating 4.0 Beta 7 or earlier. But that's always a hairy thing, updating json parameters, so I have to think about that.
if you update, we dont need to turn this "on" by default...the option is there for them to turn it on if they want...
I wanted to put at least some awareness on these update aspects because people are messing around much recently with params here and there and don't care about the update script, so what I find when digging deeper is a mess.
Got it. I'll try harder in future to make your job easier :)
A Missed opportunity of space
Massively depends on your screen size.
On my screen this PR just created extra space
We want to have a 4.0 RC soon and things like this PR may look easy at a first look .. but only if you don't care about updating and leave all database stuff alone.
Do we really need this so soon before we want to go RC?
I currently think all that stuff should be labelled as new feature and shifted to 4.1.
We should focus on bugs now.
But that's just my personal opinion.
I think the actual maths will show that I have reported and worked on many bugs as well as things like this. You cannot be in the zone, deep in layers and layers of code and bugs hunting and fixing all of the time. Sometimes you just need to work on something light, enjoyable, while sitting in a car outside your daughters extra curricular activities with a laptop balanced on your knees watching the Sun go down...
It's not up to me if things are merged, or to which branch they are merged into.
Much more interested in your mail template thing
Much more interested in your mail template thing
Which no one else was interested in.
ok so lets revert all the "by default show it" and just have it as an optional opt in feature like all the other icons in the list - that way its easy for everyone.
I think the actual maths will show that I have reported and worked on many bugs as well as things like this.
@PhilETaylor That's right, and that's much appreciated, and I haven't said anything else.
There is another PR that adds a lot more optional quickicons but I think it was merged into 4.1 as the maintainers deemed it a new feature
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-14 21:32:54 |
Closed_By | ⇒ | PhilETaylor |
and #32223 has others (@infograf768) disagreeing over whether it should have been in 4.0 and not 4.1 ;-) so its not always clear cut
We want to have a 4.0 RC soon
Is there actually a decision and a date or is this pie in the sky still?
Is there actually a decision and a date or is this pie in the sky still?
I'd say it's something in between those 2 :-)
And no one seems to see that for the real problem it is :-( /facepalm.
@PhilETaylor It's only me being a normal maintainer and not official speaker so I don't want to make official statements. All I can say is we are close to it.
Heard it all before :) ...
Note the "Items with count" configuration is NOT part of this PR, and is my bad with screenshot taking... this PR only concerns the System Information icon and not the numbers on the others.