? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
14 May 2021

Summary of Changes

Add + action for plugins to go to the installer.

Testing Instructions

Home Dashboard

Actual result BEFORE applying this Pull Request

Screenshot 2021-05-14 at 21 03 03

Expected result AFTER applying this Pull Request

Screenshot 2021-05-14 at 21 31 26

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 14 May 2021
avatar PhilETaylor PhilETaylor - change - 14 May 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category ⇒ Modules Administration
avatar PhilETaylor PhilETaylor - change - 14 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Modules Administration ⇒ Administration Language & Strings Modules
avatar Quy Quy - change - 14 May 2021
Labels Added: ?
avatar brianteeman
brianteeman - comment - 14 May 2021

I am not in favour of this PR. The plus on a module creates a new instance of a module it does not install a module.

avatar PhilETaylor
PhilETaylor - comment - 14 May 2021

or maybe this icon

Screenshot 2021-05-14 at 21 28 45

avatar PhilETaylor PhilETaylor - change - 14 May 2021
Title
…
add plugin icon in quickicon
[4] add plugin icon in quickicon
avatar PhilETaylor PhilETaylor - edited - 14 May 2021
avatar Quy Quy - test_item - 14 May 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 May 2021

Still not in favour for the same reasons.

avatar PhilETaylor
PhilETaylor - comment - 14 May 2021

Im going to change the icon as I think its better anyway...

avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Modules Administration Language & Strings ⇒ Administration Language & Strings Modules Layout
avatar PhilETaylor PhilETaylor - change - 14 May 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 14 May 2021
5d8a203 14 May 2021 avatar PhilETaylor cs
8fe1660 14 May 2021 avatar PhilETaylor cs
avatar Quy Quy - alter_testresult - 14 May 2021 - Quy: Not tested
avatar Quy Quy - test_item - 14 May 2021 - Tested successfully
avatar Quy
Quy - comment - 14 May 2021

I have tested this item ✅ successfully on ff35ade


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33883.

avatar HLeithner
HLeithner - comment - 14 May 2021

Hmm only superuser can install Plugins/extensions. Shouldn't we check the ACL before adding the plus?

I think that's true for all buttons or did I missed the check?

avatar PhilETaylor
PhilETaylor - comment - 14 May 2021

I have added the ACL check explicitly in ac6ff41

avatar brianteeman
brianteeman - comment - 14 May 2021

I am not against a quicklink to install extensions but to me it makes no sense only to do this for plugins

avatar PhilETaylor
PhilETaylor - comment - 14 May 2021

Well what else would you do it to?

Just send the PRs then ?

Sent from my iPad

On 14 May 2021, at 22:17, Brian Teeman @.***> wrote:

I am not against a quicklink to install extensions but to me it makes no sense only to do this for plugins

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

avatar brianteeman
brianteeman - comment - 14 May 2021

its introducing a new concept to the quickicon - for what benefit?

avatar PhilETaylor
PhilETaylor - comment - 14 May 2021

The same could be said for most things in Joomla 4. I give up.

avatar PhilETaylor PhilETaylor - close - 14 May 2021
avatar PhilETaylor PhilETaylor - change - 14 May 2021
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-14 21:26:50
Closed_By ⇒ PhilETaylor

Add a Comment

Login with GitHub to post a comment