Feeling Lucky
?
[#3388] - [#33535] Fixed dropdownlist generating extra </div> tag
- Closed
- 31 Mar 2014
- Medium
- Build: staging
- # 3388
- Diff
- nonumber:patch-5
- Foreign ID 33535
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The JHtmlActionsDropdown::render method creates a stray end div tag.
That causes dom/html issues.
This PR fixes that.
infograf768
- comment
- 30 Mar 2014
Does'nt it close ?<div class="btn-group">
Bakual
- comment
- 30 Mar 2014
Does'nt it close?
<div class="btn-group">
That one is closed in the layout file where it's also opened.
See for example in com_banners -> banners view: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_banners/views/banners/tmpl/default.php#L156
infograf768
- comment
- 31 Mar 2014
You are right. Weird enough: Firebug displays only one </div>...
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-31 08:53:03 |
| Title |
|
||||||
| Title |
|
||||||
Testing:
The JHtml method creates this dropdown in the backend managers (articles, banners, newsfeeds, ...)
If you look at the sourcecode you will see a
</div>to much there.It doesn't break the design for the sole reason that the code is contained within a table cell.