NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar srishty-07
srishty-07
14 May 2021

Pull Request for Issue #33798.

Testing Instructions

Go to systemm->global-config->plugin->permission

on hover, there is a jump of menu.

Actual result BEFORE applying this Pull Request

118176266-1c83f180-b429-11eb-8ced-acb732c9c5ea.mp4

Expected result AFTER applying this Pull Request

srishty

Documentation Changes Required

avatar srishty-07 srishty-07 - open - 14 May 2021
avatar srishty-07 srishty-07 - change - 14 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Administration Templates (admin) NPM Change
avatar richard67
richard67 - comment - 14 May 2021

@srishty-07 The SCSS style linter in drone complains here: https://ci.joomla.org/joomla/joomla-cms/43676/1/20

administrator/templates/atum/scss/vendor/joomla-custom-elements/joomla-tab.scss
 142:9  ✖  Expected "border-top" to come before "box-shadow"   order/properties-order
avatar srishty-07 srishty-07 - change - 14 May 2021
Labels Added: NPM Resource Changed ?
avatar srishty-07
srishty-07 - comment - 14 May 2021

Thank you @richard67

avatar brianteeman
brianteeman - comment - 14 May 2021

image

avatar Kostelano
Kostelano - comment - 14 May 2021

Maybe remove it in joomla-tab.css?

joomla-tab > ul li + li {
margin-left: 1px;
}

Screenshot_1

avatar brianteeman
brianteeman - comment - 14 May 2021

Whatever you do and wherever you do it take extra care that it doesn't break orientation=horizontal

avatar srishty-07
srishty-07 - comment - 15 May 2021

sir,
According to me, The reason for the jump in the menu is because of the border top and bottom given to the anchor tag and the default height of all li’s are the same, so due to that border there is a jump on hover,
Screenshot (69)_LI

so I added border-top and bottom as it was there on ‘a’, on hover to prevent jumping, but I am not able to manage the height of the right side border on hover, it is taking the by default height of the li.
hover

And space as shown in the picture is coming because of the transparent border-top that is given to it on hover.

avatar ceford ceford - test_item - 15 May 2021 - Tested successfully
avatar ceford
ceford - comment - 15 May 2021

I have tested this item successfully on 069d22e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33871.

avatar himanshu007-creator himanshu007-creator - test_item - 15 May 2021 - Tested successfully
avatar himanshu007-creator
himanshu007-creator - comment - 15 May 2021

I have tested this item successfully on 069d22e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33871.

avatar richard67
richard67 - comment - 15 May 2021

@srishty-07 Could you address here the issue @brianteeman discovered? Or is that a completely different thing?

avatar srishty-07
srishty-07 - comment - 15 May 2021

sir,
According to me, The reason for the jump in the menu is because of the border top and bottom given to the anchor tag and the default height of all li’s are the same, so due to that border there is a jump on hover,
Screenshot (69)_LI

so I added border-top and bottom as it was there on ‘a’, on hover to prevent jumping, but I am not able to manage the height of the right side border on hover, it is taking the by default height of the li.
hover

And space as shown in the picture is coming because of the transparent border-top that is given to it on hover.

.. @richard67 @brianteeman

avatar drmenzelit
drmenzelit - comment - 18 May 2021

@srishty-07 I did a check of the scss code, if you remove line 59
&[active], &:hover { border: 0;
and line 131
a[role=tab] { .... border-top: 1px solid transparent;
you get rid of the jump and the glitch found by Brian.

Please test it and check if the changes have side effects on other parts of the backend.

avatar srishty-07
srishty-07 - comment - 19 May 2021

@srishty-07 I did a check of the scss code, if you remove line 59
&[active], &:hover { border: 0;
and line 131
a[role=tab] { .... border-top: 1px solid transparent;
you get rid of the jump and the glitch found by Brian.

Please test it and check if the changes have side effects on other parts of the backend.

Sure ma'am will try the changes.

avatar Quy
Quy - comment - 17 Jul 2021

Closing in favor of #34813. Thanks.

avatar Quy Quy - change - 17 Jul 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-07-17 15:17:47
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 17 Jul 2021

Add a Comment

Login with GitHub to post a comment