? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
14 May 2021

Pull Request for Issue # .

Summary of Changes

See #33763 (comment) to understand the issue which this PR tries to solve. Basically, on Modules management screen, if you filter module by certain position which only has one module and you:

  • Move that module to new position using batch action
  • Or edit the module, change it to a new position

After doing the action, you will be redirected back to Modules management screen with no modules displayed and also, no position selected in the filter. You would think that it is confusing because you do not have anything in the filter, why there are no modules at all?

This PR just tries to fix that special case by make sure the selected/remember position will be available and selected in the dropdown so that you know the reason why there is no modules being displayed.

Testing Instructions

  1. Access to Modules Management from backend
  2. Try to select a position which only has one module (for example), banner position
  3. Edit the module, change the position to a different position, save it
  4. You will now being redirected to Modules Management screen
  5. Before patch, you will see a screen like below (note that there is no position selected in the position filter)
  6. After patch, the previous selected position will selected in the filter (so that you know why there is no modules - it is because you are filtering modules by that position)

Actual result BEFORE applying this Pull Request

no-modules_no_filter

Expected result AFTER applying this Pull Request

no_modules_filter_displayed

Additional Comments

I'm unsure if it is really needed. But since it is reported and I see that the UI is confusing for this case, so I make a PR to address it anyway. I have no problem if this PR is rejected :)

avatar joomdonation joomdonation - open - 14 May 2021
avatar joomdonation joomdonation - change - 14 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2021
Category Administration com_modules
avatar joomdonation joomdonation - change - 14 May 2021
The description was changed
avatar joomdonation joomdonation - edited - 14 May 2021
avatar chmst chmst - test_item - 14 May 2021 - Tested successfully
avatar chmst
chmst - comment - 14 May 2021

I have tested this item successfully on 6de3d21

This PR resolves the UX issue.
The issue is caused by the concept of positions, which as such are not stored in the database but exist only as a name in com_modules.
While from a devlopers point of view, everything was correct, it was confusing for users.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33856.

avatar sandramay0905 sandramay0905 - test_item - 14 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 14 May 2021

I have tested this item successfully on 6de3d21

@joomdonation for a user this is really needed :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33856.

avatar joomdonation joomdonation - change - 14 May 2021
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 14 May 2021

Thanks both :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33856.

avatar rdeutz rdeutz - change - 14 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-14 09:57:05
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 14 May 2021
avatar rdeutz rdeutz - merge - 14 May 2021

Add a Comment

Login with GitHub to post a comment