[#33834] - [4.0] Remove duplicate scss lines for form stylings
- Closed
- 16 Jul 2021
- Medium
- Build: 4.0-dev
- # 33834
- Diff
- eyvazahmadzada:duplicate-styles
User tests: Successful: Unsuccessful:
Pull Request for Issue #33829 .
Intro
Hello, I'm one of the applicants for GSoC 2021 for the Media Manager project and I'm glad to start contributing to Joomla by creating a pull request for this small issue.
Summary of Changes
Removed stylings from line 78-108 in /administrator/templates/atum/scss/blocks/_form.scss
Testing Instructions
Go to any page that contains a form (for example Administrator > Articles > New > Images and Links) and everything will work normally.
Actual result BEFORE applying this Pull Request
Duplicate scss code in /administrator/templates/atum/scss/vendor/bootstrap/_form.scss (from line 18-48) and in /administrator/templates/atum/scss/blocks/_form.scss (from line 78-108)
Expected result AFTER applying this Pull Request
No duplicate stylings
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33834.
Thank you @eyvazahmadzada for your contribution. You need to check the classes before removing the duplicates: if a class is a Bootstrap class (e.g. form-check) a override of the class should be in the file administrator/templates/atum/scss/vendor/bootstrap/_form.scss, if the class is specific for Atum, the class should be in administrator/templates/atum/scss/blocks/_form.scss. At least that is the logic I would expect from the scss files in the template.
| Labels |
Added:
NPM Resource Changed
?
|
||
Thank you @eyvazahmadzada for your contribution. You need to check the classes before removing the duplicates: if a class is a Bootstrap class (e.g.
form-check) a override of the class should be in the fileadministrator/templates/atum/scss/vendor/bootstrap/_form.scss, if the class is specific for Atum, the class should be inadministrator/templates/atum/scss/blocks/_form.scss. At least that is the logic I would expect from the scss files in the template.
Yes, you're right, that makes more sense. I've made a new commit to place stylings in their appropriate file.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33834.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-07-16 03:24:35 |
| Closed_By | ⇒ | eyvazahmadzada |
I have tested this item✅ successfully on 9753763
To test I searched template.css before and after npm run build:css and saw the duplicate styles disappear.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33834.