?
avatar eopws
eopws
12 May 2021

Problem identified

Have you ever noticed that /administrator/templates/atum/scss/vendor/bootstrap/_form.scss from line 18 to line 48 and /administrator/templates/atum/scss/blocks/_form.scss from line 78 to line 108 have the same styles?

The main file template.scss connects both of them and they are connected only in that file, so we can reduce one of those files.

Proposed solution

Delete styles from one of those files.

avatar eopws eopws - open - 12 May 2021
avatar joomla-cms-bot joomla-cms-bot - change - 12 May 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 May 2021
avatar richard67 richard67 - change - 12 May 2021
Title
Two files have the same content
[4.0] Two scss files have the same content
avatar richard67 richard67 - edited - 12 May 2021
avatar richard67 richard67 - change - 12 May 2021
Title
[4.0] Two scss files have the same content
[4.0] Two scss files of the Atum template have the same content for large parts
avatar richard67 richard67 - edited - 12 May 2021
avatar richard67
richard67 - comment - 12 May 2021

@eopws I was so free to adjust the title of this issue a bit so it's easier for us to categorize and to be found by the right experts.

avatar richard67 richard67 - close - 13 May 2021
avatar richard67
richard67 - comment - 13 May 2021

Closing as having a pull request. Please test #33834 . Thanks in advance.

avatar richard67 richard67 - change - 13 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-13 11:36:54
Closed_By richard67

Add a Comment

Login with GitHub to post a comment