[#33811] - [4.0] com_cpanel submenu
- Fixed in Code Base
- 13 May 2021
- Medium
- Build: 4.0-dev
- # 33811
- Diff
- brianteeman:inherit
User tests: Successful: Unsuccessful:
This PR corrects multiple issues with the menu links displayed in a card on a cpanel to make the styling match the other modules on the cpanel
- Makes font the same size
- Makes the font weight the same
- Makes the link underlined
- Makes the clickable area of the link just the text not the entire row
- Slightly increase the size of the + button
Dont forget to rebuild the css
Thanks to @Kostelano and @HimAnshu007
before
after
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
I think you broke System dashboard
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33811.
@PhilETaylor system dashboard now fixed.
- Makes the clickable area of the link just the text not the entire row
Is this correct: If there are other columns (plus-sign; hits, date) only text is clickable. If there is no other column the row is clickable (featured articles)?
If i understand your test instruction correct, "Featured Articles" should also only on text be clickable.
thats correct
I have tested this item
As comment above in single lines of text like "Featured Articles" the row is clickable, not only the text.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33811.
Thats the intended behaviour
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33811.
I have tested this item
PR works. The only thing that is confusing is what Phil mentioned - the problem of underlining for external links.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33811.
PR works. The only thing that is confusing is what Phil mentioned - the problem of underlining for external links.
Mentioned what? where?
Sorry, I'm confused. Not in this PR. But I was talking about comment #33808 (comment).
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33811.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-13 18:57:06 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thank you!
thx
Just circling back to say the + icons make so much more sense at the new size ! My eyes can actually see them now, never realised how small they were before! Thanks...
Might want to check out @ciar4n PR #33808