I have tested this item ✅ successfully on afa17df

It does as its intended to, although personally I think it looks visually worse.

Yuck :-(

I'm not a fan myself but I'm assuming this is a AA a11y requirement?

Im sure our resident expert will be along to confirm or deny this is an accessibility thing :)

Ill comment on both PRs about underlines, but it looks dreadful when you have an off-site link space and then the text link:

Is it possible to only show the underline on the text and not the whitespace between the icon and the text?

@PhilETaylor Agreed. Underline removed from icons with 2a68f4c

Im sure our resident expert will be along to confirm or deny this is an accessibility thing :)

@brianteeman Willing or not, I'm assigning that grand title to you ?

@ciar4n if you have time, could you take a look at Brian's PR at #33811 and see if there is an easy fix to fix the system dashboard icons, while retaining the good changes to the other dashboard and the + signs?

it was the removal of the flex-grow that caused the problem i think

I have tested this item ✅ successfully on 2a68f4c

If there is time for finetuning:

I have tested this item ✅ successfully on 2a68f4c

Many years ago I read somewhere that links are supposed to be visually distinguishable from adjacent text. So this fits the bill although the underline is barely visible and I agree with others it is a bit yucky. Whatever happened to the default ancient blue/purple underlined scheme?

If there is time for finetuning:

@ciar4n Do you think you could fix that, too, the underlined space between the link and any appended language badge?

RTC

Please remove RTC the issue reported by @sandramay0905 needs to be fixed

Back to pending. See previous comments.

Is it possible to only show the underline on the text and not the whitespace between the icon and the text?

Probably something like adding display: contents; to the link as the problem comes from the whitespace (newlines and tabs)

Is this PR here still needed or useful now as #33811 has been merged?

I think commit 2a68f4c is still needed ?

Underline together with icon is really too much and not required. A user must see what is a link but the icon is sufficient for that.

And that is why 2a68f4c is still needed as it removed the underline from the icon for offsite links

Is this PR here still needed or useful now as #33811 has been merged?

If #33811 is the accepted solution then maybe this PR is overkill as it makes links underlined by default where #33811 only underlines links in the cpanel modules?

@sandramay0905 Could you detail for me how to replicate? ....

@ciar4n You need a multilanguage site, you can see it on Menu Dashboard for the menus having Home set.