?
avatar enav
enav
29 Aug 2012

When articles got inserted "pagebreaks" the content plugin "pagebreak" inserts at the bottom of the article a "ul" element with 2 navigation buttons "prev" and "next" just like this:

As you people can see, when the user is at the first or last page, the navigation elements shows a "li" element with just text which makes hard does some CSS styling to that element, to solve this problem I propose the just wrap the content of the first and last navigation element with a "span" element

the file to modify in question is https://github.com/joomla/joomla-cms/blob/master/plugins/content/pagebreak/pagebreak.php#L313

line: 313 and 323

With something like:

$next = "" . JText::_('JNEXT') . "";

and

$prev = "" . JText::_('JPREV') . "";

This change is minimum and doubt it will cause any kind of issue, and developers would be able to do some styles like this

.pagination li span { //style for disable button }
.pagination li a { //style for enabled button }

here is the pull request

#337

I hope I'm doing this correctly

avatar enav enav - open - 29 Aug 2012
avatar realityking
realityking - comment - 29 Aug 2012

Pull requests are github issues too, so you don't have to open a separate one. Just include the description into the pull request.

However currently we still use the joomlacode tracker. Please open an issue there: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

avatar zero-24 zero-24 - close - 4 May 2013
avatar nicksavov
nicksavov - comment - 4 May 2013

I went ahead and submitted the tracker item:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=30839

I'm going to go ahead and close this one since it's on JoomlaCode. Use the tracker item above instead.

Thanks again, Edric!

avatar nicksavov nicksavov - close - 4 May 2013
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
Removed: ?
Build staging

Add a Comment

Login with GitHub to post a comment