? NPM Resource Changed Information Required Pending

User tests: Successful: Unsuccessful:

avatar eopws
eopws
11 May 2021

Summary of Changes

Fixed minor problem in com_cpanel by adding needed css

Testing Instructions

Go to administrator > com_cpanel and hover on the "Add module to the dashboard" button

Actual result BEFORE applying this Pull Request

The box with cross inside has no changes in color when mouse is on the outer box
before

Expected result AFTER applying this Pull Request

The box with cross inside has changed its color to white when mouse got on the outer box
after

avatar eopws eopws - open - 11 May 2021
avatar eopws eopws - change - 11 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2021
Category Administration Templates (admin) NPM Change
avatar brianteeman
brianteeman - comment - 11 May 2021

Why do you think the current behaviour is a problem. It is exactly the same as all the dashboard icons

avatar eopws
eopws - comment - 11 May 2021

Why do you think the current behaviour is a problem. It is exactly the same as all the dashboard icons

On my opinion when the box is white you can see it better

avatar brianteeman
brianteeman - comment - 11 May 2021

So why are you not proposing to change all the icons?

avatar eopws
eopws - comment - 11 May 2021

So why are you not proposing to change all the icons?

I didn't spot that all the dashboard icons have the same problem.

avatar eopws
eopws - comment - 11 May 2021

So why are you not proposing to change all the icons?

I will open new PR to change all the icons. Thank you for remark.

avatar brianteeman
brianteeman - comment - 11 May 2021

Have you not considered that this was a deliberate design decision?

avatar eopws
eopws - comment - 11 May 2021

Have you not considered that this was a deliberate design decision?

Maybe it is, but don't you think that it looks a bit weird?

avatar brianteeman
brianteeman - comment - 11 May 2021

I am not a designer ;)

avatar Quy
Quy - comment - 11 May 2021

The focus should be on the text and not the icon.

avatar eopws
eopws - comment - 11 May 2021

The focus should be on the text and not the icon.

So we shouldn't change icons, right?

avatar Quy
Quy - comment - 11 May 2021

I am fine as it, but that is just my preference.

avatar eopws
eopws - comment - 11 May 2021

I think I touched too subjective topic. Okay, let's wait for more people to tell their opinion.

avatar ceford
ceford - comment - 12 May 2021

IMHO, with the background turning dark blue on hover, the icons should turn white.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33786.

avatar sandramay0905
sandramay0905 - comment - 12 May 2021

I'm not a designer and let decide @ciar4n (thanks for your work), who repaint the backend.

avatar eopws
eopws - comment - 20 May 2021

Have you not considered that this was a deliberate design decision?

It's the way the icons done in joomla 4.1

img

But joomla 4.1 has a lot of changes in design, so we still need to wait for a designer's decision

avatar brianteeman
brianteeman - comment - 20 May 2021

But joomla 4.1 has a lot of changes in design, so we still need to wait for a designer's decision

It shouldnt have any

avatar eopws eopws - change - 13 Nov 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-11-13 08:01:46
Closed_By eopws
Labels Added: ? NPM Resource Changed Information Required
avatar eopws eopws - close - 13 Nov 2021

Add a Comment

Login with GitHub to post a comment