[#33769] - Makes check for field type="Hidden" case-insensitive
- Fixed in Code Base
- 12 May 2021
- Medium
- Build: 4.0-dev
- # 33769
- Diff
- regularlabs:patch-5
User tests: Successful: Unsuccessful:
Fixes issue with field not being seen as hidden when using type="Hidden" instead of type="hidden"
You can test this by for instance - changing:
<field
name="update_site_id"
type="hidden"
/>
to:
<field
name="update_site_id"
type="Hidden"
/>
in administrator/components/com_installer/forms/updatesite.xml
Then go to administrator/index.php?option=com_installer&view=updatesites and click on one of the update sites.
Result is now:
After fix, that line is not visible (which is good).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Well, all field types are already case-insensitive... kind of.
If the Field classname is FoobarField, then the casing doesn't matter.
So you can use type="list", or type="List" or even type="LiSt"... but not type="Hidden"
Depending on your server (whether it can deal with case-insensitive files/folders) you DO need to use the exact casing when using other uppercase characters in the classname, like FooBarField.
Then you must use field="FooBar" or field="fooBar", but field="foobar" will fail.
Joomla uses a mix of the lowercase and title case class name (yes, bit of a mess):
Anyway, this PR is just to fix the issue with the type="Hidden"
PS: Here you can already see that there are other internal checks on the type that are case-insensitive.
joomla-cms/libraries/src/Form/FormField.php
Line 908 in ad9eba8
I have tested this item
Marking as successful that it does what it says. reserving judgement due to lack of knowledge if this is the correct approach
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33769.
I have tested this item
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33769.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33769.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-12 09:49:11 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
Thanks!
Surely if you are making this case-insensitive then you need to make them all case insensitive?