Feeling Lucky
?
?
[#33756] - [4.0] Header height atum
- Fixed in Code Base
- 11 May 2021
- Medium
- Build: 4.0-dev
- # 33756
- Diff
- brianteeman:header_height
User tests: Successful: Unsuccessful:
Buttons have a padding of 1px defined in the browser unless it is specified in the css
On the toolbar they might all look like buttons but only the last one (user) is a button. Therefore that one is 68px and the others are 66px.
This results in a 2px difference in the height of the header as shown in the reported issue.
This PR removes the browser padding top and bottom and therefore the header is always 66px high.
Pull Request for Issue #33755.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
sandramay0905
- comment
- 11 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33756.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 11 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33756.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-11 13:01:34 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 11 May 2021
Thanks
brianteeman
- comment
- 11 May 2021
thx
I have tested this item✅ successfully on 9e16233
Pixel perfection!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33756.