Feeling Lucky
?
?
[#33746] - [4.0] Smart Search: Adding index to taxonomy table
- Fixed in Code Base
- 26 May 2021
- Medium
- Build: 4.0-dev
- # 33746
- Diff
- Hackwar:j4finderindexes
User tests: Successful: Unsuccessful:
During some testing, the taxonomy table of the Smart Search component showed to be a performance problem, especially on sites with lots of taxonomies. The index being added in here improves this performance enormously. There isn't really any way to test this for the regular users. This needs a codereviews.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql Installation |
| Labels |
Added:
?
|
||
alikon
- comment
- 24 May 2021
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33746.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 24 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33746.
alikon
- comment
- 24 May 2021
i'll let someonelse to set rtc
...if my code review still value
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-26 11:55:54 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 0a63748
Code review is not enough. I tested also that updating a current 4.0-dev to the custom update URL built by drone for this PR works without SQL errors and that the index has been created, on both MySQL and PostgreSQL. The reason is that we don't have automated tests for that yet. That the SQL for new installations doesn't have syntax errors is already checked with the automated system tests.
I did not test if the new index improves performance, but I think it will do that.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33746.