[#33726] - [4.0] Changed color of Joomlaversion
- Fixed in Code Base
- 12 May 2021
- Medium
- Build: 4.0-dev
- # 33726
- Diff
- himanshu007-creator:Color-change
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
changed the color of joomlaversion on top. Earlier it had gray color,but not now
Testing Instructions
apply this patch, build the CSS and observe the joomlaversion
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
@sandramay0905 , please test again, Thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.
@himanshu007-creator I am not sure if the new colours meet the contrast requirements for AA regarding a11y.
No problem with contrast
Yes, I've just checked, contrast is AAA, and monochrome also still works.
But I don't really see any advantage in this PR.
@richard67 this patch helps to establish a sort of distinction for Joomlaversion . This separates it from other Header items as It only displays the current Joomla! version.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.
Well, colours are a matter of taste. I'm ok with this PR. I just don't want that we change colours forth and back because some people like this and others like that colour. I'll merge this now in the hope not to get issues or PRs about inconsistent colouring of the title bar.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-12 09:45:41 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 5e15bbe
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33726.