? ? Pending

User tests: Successful: Unsuccessful:

avatar himanshu007-creator
himanshu007-creator
9 May 2021

Pull Request for Issue #33703.

Summary of Changes

No more Double Click

Testing Instructions

go to System -> Global config -> server tab
for Database Password field click on Modify Button.

Actual result BEFORE applying this Pull Request

Click TWICE on modify to enable the field and allow changes.

Expected result AFTER applying this Pull Request

ONE CLICK is all it take
new

Documentation Changes Required

avatar himanshu007-creator himanshu007-creator - open - 9 May 2021
avatar himanshu007-creator himanshu007-creator - change - 9 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2021
Category Layout
avatar himanshu007-creator himanshu007-creator - change - 9 May 2021
The description was changed
avatar himanshu007-creator himanshu007-creator - edited - 9 May 2021
avatar PhilETaylor PhilETaylor - test_item - 9 May 2021 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 9 May 2021

I have tested this item successfully on 68ad2fe

Thanks.

Please prepend [4] to the title of your PR so that it can be seen to apply to the correct branch although @richard67 will probably know :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33708.

avatar himanshu007-creator himanshu007-creator - change - 9 May 2021
Title
Fixed double click error
[4.0] Fixed double click error
avatar himanshu007-creator himanshu007-creator - edited - 9 May 2021
avatar rjharishabh rjharishabh - test_item - 9 May 2021 - Tested successfully
avatar rjharishabh
rjharishabh - comment - 9 May 2021

I have tested this item successfully on 68ad2fe

PR works fine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33708.

avatar richard67 richard67 - change - 9 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 9 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33708.

avatar richard67 richard67 - change - 9 May 2021
The description was changed
avatar richard67 richard67 - edited - 9 May 2021
avatar richard67
richard67 - comment - 9 May 2021

@himanshu007-creator I've just removed a smiley (emoji) from the description of this PR after the text **ONE CLICK** is all it take. The CI tool (namely Drone) doesn't like that and now is hanging. Could you update your branch to latest 4.0-dev and push again? Or let me know if I shall do that for you. Update: I will do that for you 'cause in your time zone it is already late. Please in future no emojis in PR titles or descriptions.

avatar himanshu007-creator
himanshu007-creator - comment - 9 May 2021

@himanshu007-creator I've just removed a smiley (emoji) from the description of this PR after the text **ONE CLICK** is all it take. The CI tool (namely Drone) doesn't like that and now is hanging. Could you update your branch to latest 4.0-dev and push again? Or let me know if I shall do that for you. Update: I will do that for you 'cause in your time zone it is already late. Please in future no emojis in PR titles or descriptions.

please can you do it for me @richard67 . Thanks in advance, and regarding the emoji part, i will be careful in future

avatar richard67 richard67 - change - 9 May 2021
Labels Added: ? ?
avatar richard67 richard67 - alter_testresult - 9 May 2021 - PhilETaylor: Tested successfully
avatar richard67 richard67 - alter_testresult - 9 May 2021 - rjharishabh: Tested successfully
avatar richard67
richard67 - comment - 9 May 2021

Done. Drone running. Will merge as soon as CI checks are ok.

avatar richard67 richard67 - close - 9 May 2021
avatar richard67 richard67 - merge - 9 May 2021
avatar richard67 richard67 - change - 9 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-09 18:35:43
Closed_By richard67
avatar richard67
richard67 - comment - 9 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment