Feeling Lucky
NPM Resource Changed
?
?
[#33688] - [4.0] com_media drag and drop
- Fixed in Code Base
- 9 May 2021
- Medium
- Build: 4.0-dev
- # 33688
- Diff
- brianteeman:mediadrag
User tests: Successful: Unsuccessful:
The dropzone is the height of the media-browser div. Before this PR that height was dependent on the height of the content. Now it is the full height of the div.
its a css change so npm i
Test
The easiest way is to create a new folder in the media manager and try to upload a new file using dragdrop.
Before
After
Pull Request for Issue #33604
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
richard67
- comment
- 9 May 2021
@brianteeman Could you fix scss code style? The linter says:
build/media_source/com_media/scss/components/_media-browser.scss
6:3 ✖ Expected "min-height" to come before "transition" order/properties-ord
| Labels |
Added:
NPM Resource Changed
?
|
||
richard67
- comment
- 9 May 2021
I've restored the previous test result in the issue tracker since the commit which invalidated it was just a code style change.
saumyasarkar11
- comment
- 9 May 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33688.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 9 May 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33688.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-09 13:28:10 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
richard67
- comment
- 9 May 2021
Thanks!
brianteeman
- comment
- 9 May 2021
Thanks.
I have tested this item✅ successfully on 278dbc4
Perfect thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33688.