Feeling Lucky
?
[#33685] - [4.0] Remove BannersHelper class
- Closed
- 9 May 2021
- Medium
- Build: 4.0-dev
- # 33685
- Diff
- joomdonation:remove_banner_helper
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The class BannersHelper is just an alias for Joomla\Component\Banners\Administrator\Helper\BannersHelper class and from I can see, it is not used anywhere, so I propose to remove it to to make the component looks a bit cleaner (it is strange to see a blank class extends the actual namespace class like that)
Testing Instructions
Testing is not needed. Leave it to @wilsonge to decide if he wants to accept this removal PR.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-09 09:00:00 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
?
|
||
Ah, just saw the deprecated message, we could not remove it until 5.0