Joomla! Issue Tracker | Joomla! CMS #33663

Closed
8 May 2021
Medium
Build: staging
# 33663

PhilETaylor
8 May 2021

after running the commands to build everything from git, recently Ive been getting build_incomplete.html and fatal-error.html as modified files.

The only difference is the language

Im not aware of having chosen a default language yet, is this something that needs fixing?

PhilETaylor - open - 8 May 2021

joomla-cms-bot - change - 8 May 2021

Labels

Added: ?

joomla-cms-bot - labeled - 8 May 2021

PhilETaylor - change - 8 May 2021

The description was changed

PhilETaylor - edited - 8 May 2021

dgrammatiko - comment - 8 May 2021

This is my mistake, I forgot to order the languages when I redid the tooling. It's an easy fix
replace

joomla-cms/build/build-modules-js/error-pages.es6.js

Line 115 in ddc1380

    
           const jsonContent = `window.errorLocale=${JSON.stringify(global[`${name}Obj`])};`;

with

const sortedJson = Object.fromEntries(Object.entries(global[`${name}Obj`]).sort());
const jsonContent = `window.errorLocale=${JSON.stringify(sortedJson)};`;

fwiw I've tried to change this in another PR https://github.com/joomla/joomla-cms/pull/33170/files but that one has other issues with the CI...

PhilETaylor - change - 8 May 2021

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2021-05-08 21:48:00
Closed_By		⇒	PhilETaylor

PhilETaylor - close - 8 May 2021

PhilETaylor - comment - 8 May 2021

[4] en-GB verses en-US - order the languages #33674

dgrammatiko - comment - 8 May 2021

BTW ordering is irrelevant on the runtime as the object is used by using the key (eg en-GB)

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#33663] - [4] en-GB verses en-US?

Add a Comment