[#33654] - Fix some admin error page issues
- Fixed in Code Base
- 8 May 2021
- Medium
- Build: 4.0-dev
- # 33654
- Diff
- ciar4n:define-default-colors
User tests: Successful: Unsuccessful:
Pull Request for Issue #33599 #33612 .
Summary of Changes
Defines defaults for template color variables / Fixes header btn alignment.
Testing Instructions
Logout of Joomla 4 admin
Go to a URL that generates a 403 Forbidden message - here is a quick example:
http://example.com/administrator/index.php?option=com_banners&task=tracks.display&format=raw
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
Yes I think so... the header button alignment is fixed here
This fixes the reported issue with text color for sure, but
- The bottom blue box in the left sidebar changes between the error page and the login page (hard to see in the video, but there is a padding missing somewhere)
- There is a 'view website' link on the error page in the left menu bar, this needs to either be "View website" or removed I guess. #33656
Screen.Recording.2021-05-08.at.07.06.50.pm.mp4
Happy to mark this as a successful test though as it resolves the reported issue and gets the error page to a useable state
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33654.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33654.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33654.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33654.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-08 20:29:48 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Thank you!
@ciar4n Do I assume right that this PR also makes PR #33649 obsolete?