[#33651] - [4.0] use J4 namespacing
- Fixed in Code Base
- 9 May 2021
- Medium
- Build: 4.0-dev
- # 33651
- Diff
- hans2103:feature/33599-adjust-namespacing
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #33599 .
Summary of Changes
This PR will change some J3 classNames by J4 namespaced classNames in Atum template
Testing Instructions
just code change without visual change.
Actual result BEFORE applying this Pull Request
no visual changes to be expected.
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
It works but I'm unsure if the changed is needed. My my personal preference is keep using the fully qualified names for these lines of code. The reason is that it is only used in comment to help IDE to find the right class, so adding use statement is not necessary.
| Title |
|
||||||
Emoji removed.
I think JDocumentHtml and JDocumentError are J3.
Since we're moving to J4 those classes need to be changed to HtmlDocument and ErrorDocument.
The reason to move it to use is be consistent with the rest. Just a way to write code... keeping all use stuff on one place.
| Labels |
Added:
?
|
||
I think JDocumentHtml and JDocumentError are J3.
You are right and I agree with that. I just want to say that the class is not really used, it is used to help IDE only. So I would write it like this https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/error_full.php#L19 (save the system from having to run an unnecessary use command)
But as I said, it's not a big thing. It is just my own preference only.
@joomdonation thank you for clear explanation. Used your suggestion
Please test my PR.
I have tested this item
Looks good now. Thanks :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33651.
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33651.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33651.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-09 18:01:58 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
please try not to use (or attempt to use) emoji in titles.
At best they dont work and are meaningless
At worse they break drone