User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Keep files and folder deletion in script.php up to date with recent changes on the 4.0-dev branch.
With these changes, the files and folders deletion in script.php will be up to date with all what the tool I use for generating the lists generates right now with latest 3.10-dev and 4.10-dev branches.
To be tested and merged after PR #33437 has been merged. Will keep it in draft status until then.
Code review:
$files
array within the section after the // 4.0 from Beta 7 to Beta 8
comment in script.php.$folders
array within the section after the // 4.0 from Beta 7 to Beta 8
comment in script.php.Alternatively do a real test with updating a current 4.0-dev or latest nightly to the update package or custom URL created by Drone for this PR and checking that the files are really removed by the update.
The one files and the one folder removed with PR #33390 from the sources and the changelog of tinymce will not be deleted with a CMS update.
The one files and the one folder removed with PR #33390 from the sources and the changelog of tinymce will be deleted with a CMS update.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
its a bug if that changelog is being created
@brianteeman I don't understand. Do you mean it's a but if it's in the package? Then the bug has been solved, and so it comes that it is not in the package anymore. Or do you mean it is a bug that it is added to the list of files to be deleted here?
the contents of the media/vendor/tinymce folder are created by our build scripts. If there is a changelog in that folder then its a bug and we need to check the build scripts to make sure it is not added to media/vendor/tinymce
@brianteeman The files was in the folder with 4.0 Beta 7. The list in this PR here has been updated based on the difference between a newly build package locally on my current and clean 4.0-dev, and in that new build the file was not in and so it's added to the list here. So the bug was in Beta 7 and maybe earlier and has meanwhile been solved.
@brianteeman I think it was PR #32300 which fixed it, and that came after Beta 7, so that could explain it.
Labels |
Added:
?
|
Title |
|
Ready for tests.
I have tested this item
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-09 13:30:56 |
Closed_By | ⇒ | wilsonge |
Thanks!
its a bug if that changelog is being created