[#33640] - Change .media-preview-close position
- Closed
- 10 May 2021
- Medium
- Build: 4.1-dev
- # 33640
- Diff
- eopws:patch-3
User tests: Successful: Unsuccessful:
Summary of Changes
Changed modal image close button position in media component.
Changed in order to make the button look nicer.
Testing Instructions
Go to administrator > media > open any image
Actual result BEFORE applying this Pull Request
The button is far away from the image. It looks like a mistake in layout
Expected result AFTER applying this Pull Request
The button is close to the image.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
@eopws The 4.0 dev branch is used for the upcoming Joomla version 4.0, and the 4.1 dev branch for new features which will go into the later 4.1 version. The 4.0-dev branch is up to date with all pull requests we have merged for 4.0, while the 4.1-dev branch will be updated with those later. The 4.1-dev branch we have here only for pull requests which introduce new features which can't go into 4.0 due to the feature freeze in the Beta phase of 4.0.
So I have redo this pull request to the 4.0-dev branch, right?
Just click on edit - top right
and then change the base branch to 4.0 from the dropdown
Just click on edit - top right
and then change the base branch to 4.0 from the dropdown
Thank you
| Labels |
Added:
NPM Resource Changed
?
|
||
| Category | Repository NPM Change | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-10 11:25:50 |
| Closed_By | ⇒ | eopws | |
| Labels |
Added:
?
Removed: NPM Resource Changed |
||
| Category | Repository Unit Tests Administration com_admin SQL Postgresql | ⇒ | Unit Tests com_tags Administration com_users Language & Strings Modules Repository NPM Change Libraries Front End Plugins |
@eopws What's the reason why you've made this PR for the 4.1-dev branch and not for 4.0-dev? Is it a new feature so it has to wait until 4.1?