User tests: Successful: Unsuccessful:
In the repaint the background image was removed and this has had the side effect of breaking the ability to make the screen monochrome. This PR reverts fixes that change.
To test apply the pr and rebuild the css
Then go to the template admin styles for admin and set the color to monochrome
Before this PR the background stays blue
With this PR the background is monochrome
pr for #33602
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
If the background pattern is reverted then each icon and learn more buttons in empty states needs revisiting as the icons and buttons are transparent so the pattern shows through them - cant remember which icon that was a problem for, but was for all the learn more buttons
Plus anywhere else things are transparent get placed on the background directly (cant think of any) need revisiting
I am not in love with the background pattern but it was the only solution I could find for this problem. Maybe someone can find a better solution
I have tested this item
I am not in love with the background pattern but it was the only solution I could find for this problem. Maybe someone can find a better solution
@ciar4n Do you have an idea if there is a way to fix the monochrome background being not monochrome issue without using that background pattern?
hm, I wonder how the pattern fixing the color?
Revert all your changes, and try just:
&.monochrome {
filter: grayscale(1);
&::after {
position: fixed;
top: 0;
left: 0;
z-index: -1;
width: 100%;
height: 100%;
content: "";
background: var(--atum-bg-dark-5);
}
}
In some reason filter: grayscale(1);
does not applies to the element background, but applies for children.
@brianteeman Could you check the above comment by @Fedik and maybe implement it that way?
Labels |
Added:
NPM Resource Changed
?
|
Title |
|
Changed the code to use @Fedik version - thanks and to keep @PhilETaylor happy does not reintroduce the background
keep @PhilETaylor happy does not reintroduce the background
Wasn't the background pattern meant to be a major new feature of Joomla 4 (2017 edition)...
https://magazine.joomla.org/images/2017/12/j4backend_design/20171204_Joomla_Pattern.pdf
you wanted it removed so its removed
@Quy @sandramay0905 Could you test again? There has been made a change. Thanks in advance.
you wanted it removed so its removed
Factually correct.
Also now the patterned background (a personal dislike of mine) is visual and messes with my head on empty states, and bleeds into the learn more button
Nothing in that sentence is asking for it to be removed.
It was @ciar4n that made their own decision to remove it.
I also raised an issue detailing the issue with it and Empty States as a
reminder to revisit the transparency of the icons and the Learn More buttons
At no time did I "want" or demand that it was removed. Please do not put words into my mouth.
I'm just fixing a bug after the changes made in the repaint
I have tested this item
So much better. I might just always use monochrome. Looks amazing.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-09 19:15:13 |
Closed_By | ⇒ | chmst | |
Labels |
Added:
?
|
Thanks
thx
I have tested this item✅ successfully on f1ed16e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33636.