NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar simbus82
simbus82
7 May 2021

Pull Request for Issue #33627 .

Summary of Changes

Added an overflow: hidden to the .sidebar-wrapper .sidebar-sticky class in /administrator/templates/atum/scss/blocks/_sidebar.scss

Testing Instructions

Try to Toggle sidebar menu in Joomla 4 backend.
You see the "submenu" rendered before the full sidebar.
With this patch it is rendered correctly.

Actual result BEFORE applying this Pull Request

issue-joomla

Expected result AFTER applying this Pull Request

issue-solved-joomla

Documentation Changes Required

None.

avatar simbus82 simbus82 - open - 7 May 2021
avatar simbus82 simbus82 - change - 7 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2021
Category Administration Templates (admin) NPM Change
avatar brianteeman brianteeman - test_item - 7 May 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 7 May 2021

I have tested this item ? unsuccessfully on 5c4b3e1

When the sidebar is collapsed you now can't see the flyout menu items


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33628.

avatar richard67
richard67 - comment - 7 May 2021

Beside the above, the PR also has SCSS code style errors reported here: https://ci.joomla.org/joomla/joomla-cms/43224/1/20 :

> stylelint --config build/.stylelintrc.json -s scss "administrator/components/com_media/resources/**/*.scss" "administrator/templates/**/*.scss" "build/media_source/**/*.scss" "templates/**/*.scss" "installation/template/**/*.scss"


administrator/templates/atum/scss/blocks/_sidebar.scss
 12:5  ✖  Expected "top" to come before "overflow"   order/properties-order
avatar simbus82
simbus82 - comment - 7 May 2021

I have tested this item ? unsuccessfully on 5c4b3e1

When the sidebar is collapsed you now can't see the flyout menu items

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33628.

Right, It's needed to check when the sidebar is closed, so we don't have to hide the flyouts.
This is working for me.

#wrapper:not(.closed) .sidebar-wrapper .sidebar-sticky {
    overflow: hidden;
}

I try to add this in the SCSS.

avatar simbus82 simbus82 - change - 7 May 2021
Labels Added: NPM Resource Changed ?
avatar richard67
richard67 - comment - 7 May 2021

@simbus82 And still the linter compains about the same as before:

administrator/templates/atum/scss/blocks/_sidebar.scss
 8:3  ✖  Expected "overflow" to come before "box-shadow"   order/properties-order

So please fix as advised here by the linter.

Thanks in advance.

avatar simbus82
simbus82 - comment - 7 May 2021

I have found a better way!
(Also because it is not easy to understand in which scsss file I should have put the style for the "#wrapper:not(.closed) .sidebar-wrapper .sidebar-sticky").

.sidebar-wrapper with overflow: hidden, and when ".closed" with overflow: visibile, so the flyout menu can be visible.

If there are no other "hidden" functions, I also tried it from mobile and it doesn't give any problems.

Could you kindly test if it works well?

@simbus82 And still the linter compains about the same as before:

administrator/templates/atum/scss/blocks/_sidebar.scss
 8:3  ✖  Expected "overflow" to come before "box-shadow"   order/properties-order

So please fix as advised here by the linter.

@richard67 sorry, i don't use a linter.

avatar richard67
richard67 - comment - 7 May 2021

@richard67 sorry, i don't use a linter.

@simbus82 At the bottom of the PR you can find the failed tests and follow the links there which at the end lead to the logile showing that. And for your convenience I pasted it here. What else can I do to make you to fix it? It tells you lind number and file and what to fix.

avatar simbus82
simbus82 - comment - 7 May 2021

@richard67 sorry, i don't use a linter.

@simbus82 At the bottom of the PR you can find the failed tests and follow the links there which at the end lead to the logile showing that. And for your convenience I pasted it here. What else can I do to make you to fix it? It tells you lind number and file and what to fix.

I was apologizing for not using it in the process, sorry! I'm used to alphabetical order ?

avatar brianteeman
brianteeman - comment - 7 May 2021

administrator/templates/atum/scss/blocks/_sidebar.scss

8 | 7:3 Expected "overflow" to come before "background-color" order/properties-order

avatar brianteeman
brianteeman - comment - 7 May 2021

other than the code style issue above this works great

avatar ceford ceford - test_item - 9 May 2021 - Tested successfully
avatar ceford
ceford - comment - 9 May 2021

I have tested this item successfully on e75125f

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33628.

avatar sandramay0905 sandramay0905 - test_item - 9 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 9 May 2021

I have tested this item successfully on e75125f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33628.

avatar alikon alikon - change - 9 May 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 9 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33628.

avatar richard67 richard67 - close - 9 May 2021
avatar richard67 richard67 - merge - 9 May 2021
avatar richard67 richard67 - change - 9 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-09 10:46:53
Closed_By richard67
Labels Added: ?
avatar richard67
richard67 - comment - 9 May 2021

Thanks!

avatar simbus82
simbus82 - comment - 10 May 2021

Thanks to you guys!

Add a Comment

Login with GitHub to post a comment