? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 May 2021

Because the icons are different widths the padding looks a little off. By using the fixed width version of the icons its much better.

Before

image

After

image

Pull Request for Issue #33591

avatar brianteeman brianteeman - open - 7 May 2021
avatar brianteeman brianteeman - change - 7 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2021
Category Modules Administration
avatar sandramay0905 sandramay0905 - test_item - 7 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 7 May 2021

I have tested this item successfully on 8a6989d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33622.

avatar alikon alikon - test_item - 7 May 2021 - Tested successfully
avatar alikon
alikon - comment - 7 May 2021

I have tested this item successfully on 8a6989d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33622.

avatar alikon alikon - change - 7 May 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 7 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33622.

avatar PhilETaylor
PhilETaylor - comment - 7 May 2021

Happy for this to get merged as its slightly better but Im still not convinced - the Envelope and 3 still seem offset to the left of the cutout shape to me.

The distance between the back of the 3 and the side is much more than the left side of the envelope and the left side of the cutout

Screenshot 2021-05-07 at 10 25 51

Not tested but can it handle 999 messages ?

avatar brianteeman
brianteeman - comment - 7 May 2021

Not tested but can it handle 999 messages ?

of course

image

avatar PhilETaylor
PhilETaylor - comment - 7 May 2021

but that just makes the offset to the left even worse. Makes it look like there is no padding at all on the left.

avatar alikon
alikon - comment - 7 May 2021

i still think we could spend our free time better
....but that's me

avatar richard67 richard67 - change - 7 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-07 12:54:59
Closed_By richard67
Labels Added: ? ?
avatar richard67 richard67 - close - 7 May 2021
avatar richard67 richard67 - merge - 7 May 2021
avatar richard67
richard67 - comment - 7 May 2021

Thanks!

avatar brianteeman
brianteeman - comment - 7 May 2021

thank you

Add a Comment

Login with GitHub to post a comment