[#33616] - [4.0] version history toolbar
- Closed
- 7 May 2021
- Medium
- Build: 4.0-dev
- # 33616
- Diff
- brianteeman:rainbow
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33616.
I have tested this item
While this PR does remove the rainbow colours it still doesn't implement the icon colours like the Joomla standard toolbars which was the expectation, to keep the toolbar in keeping with the rest of toolbars in Joomla 4
There also seems to be a lack of space between the icons and the text
Examples of Joomla "standard" toolbars:
And this PR's result:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33616.
fine fix it yourself. you're never happy
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-07 10:44:35 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
fine fix it yourself. you're never happy
What a pathetic response. This is nothing to do with ME, this is about Joomla and making Joomla better.
If I had submitted this PR you would have been all over it moaning.
its missing margin-inline-end: .5rem; which would give it to the spacing etc it probably needs to be rewritten to use the joomla-toolbar-button - if i get a chance later today I will give it a try
Its missing a hell of a lot more than that. Its missing correct implementation in the MVC view in PHP with the Toolbar instance and rendering using reusable custom-elements instead of hard coding a set of buttons in a view.
Im almost complete.
yes thats why the toolbar needs to be rewritten from scratch instead of being hard coded
i like the rainbow coming from #33532 ...my personal taste