I think it would be a good idea to bite the bullet and add a composer.json file to the CMS and bring in dependencies that way (and that paves the way for the CMS to use other packages from other vendors).

I think it would be a good idea too :P But I really would like to avoid if possible doing it in this PR. In part because I wanna keep this to the feature and get it in in time for 3.3. But more in part because I'm a coward and I don't want to be responsible if I balls it all up :D

Don and I have branches that already attempt it. I agree, leave it off for 3.3 but I strongly believe we need to be pushing to remove the 3.5 cap on the 3.x series of the CMS. I know the PLT is working on a plan so hopefully it won't be too long before that comes out for public comment. Then we can do these things in feature rather than calendar increments.

sounds like a plan to me :) My other issue is working out the workflow. In many apps you just call the composer install on download but obviously in the CMS that won't be the case. Also for example you take the full application package then your also implicitly autoloading the Input, Event, Session, String, Registry, Uri, Filesystem and PSR log package :P Which is significantly more than the half a package I'm adding lol

Yes I understand. What if you moved all the JF files into the likely
"future" location, but we just don't use Composer. That is, move DI and
your file to `/vendor/joomla-framework/..."?

It seems like a good compromise to me :) How does that look?

I guess this is where we start going down the rabbit hole.

The path for the CLI tools will look something like /vendor/joomla/application/src/Cli/.... The path for DI will be /vendor/joomla/di/src/....

Well as we're not using PSR-4 yet can we use src yet? I'm not sure that would still work with the JLoader functions we have (haven't tested this hypothesis however)

I think our loader can cope with it as long as you include the full path,
and you'll have to register each package. I think:

JLoader::registerNamespace('Joomla', JPATH_ROOT .
'/vendor/joomla/application/src');


JLoader::registerNamespace('Joomla', JPATH_ROOT . '/vendor/joomla/di/src');

will work?

Ah, that won't work. Ok, just leave the files where they were and
we'll fix it later.

What so in the vendor path or in the libraries/framework path?

I think put the files back under /libraries/framework for now and we'll
sort out Composer another time. Sorry for the distraction.

Nah no worries! It was worth a shot!

Right reverted the vendor commit - lets just run with this as is :)