? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
6 May 2021

Summary of Changes

Add col-md-6 class

Testing Instructions

Dashboard > Content > Workflows > Click on any workflow

Actual result BEFORE applying this Pull Request

before-workflow

Expected result AFTER applying this Pull Request

after-workflow

Documentation Changes Required

None

avatar rjharishabh rjharishabh - open - 6 May 2021
avatar rjharishabh rjharishabh - change - 6 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 May 2021
Category Administration com_workflow
avatar rjharishabh rjharishabh - change - 6 May 2021
Title
add col-md-6
[4.0] Change width in com_workflow
avatar rjharishabh rjharishabh - edited - 6 May 2021
avatar rjharishabh rjharishabh - change - 6 May 2021
Labels Added: ?
avatar brianteeman
brianteeman - comment - 6 May 2021

Did you work out why the field is even displayed?

avatar rjharishabh
rjharishabh - comment - 6 May 2021

Did you work out why the field is even displayed?

Yes, translation of the workflow item title

avatar brianteeman
brianteeman - comment - 6 May 2021

Really? Will it show you multiple languages?

avatar rjharishabh
rjharishabh - comment - 6 May 2021

I think, When multiple languages are present, in the above image en-GB

avatar brianteeman
brianteeman - comment - 6 May 2021

I have tried and I can only ever get it to show one

avatar infograf768
infograf768 - comment - 6 May 2021

maybe: debug lang on, switch backend language to fr-FR for example. The pack is j3.

can’t test as not on desktop

avatar brianteeman
brianteeman - comment - 6 May 2021

Just one language

image

avatar infograf768
infograf768 - comment - 6 May 2021

That’s it.
If you create the missing strings in the admin language, then you should get the translation.
If I remember well, the name of. the workflow should also be a string constant.
Same behavior as custom admin menu items.

avatar brianteeman
brianteeman - comment - 6 May 2021

But shouldnt it display the value of the constant in all admin languages ?

avatar brianteeman
brianteeman - comment - 6 May 2021

Maybe I am confused and that was never a feature. I was just expecting to see a readonly field with the text for each language on the site

avatar rjharishabh rjharishabh - change - 8 May 2021
The description was changed
avatar rjharishabh rjharishabh - edited - 8 May 2021
avatar ceford ceford - test_item - 9 May 2021 - Tested successfully
avatar ceford
ceford - comment - 9 May 2021

I have tested this item successfully on 145969b

Sticking to the point - this pr does make the Name (en-GB) field the same width as the Name field. But ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33581.

avatar ceford
ceford - comment - 9 May 2021

The form clearly needs some work. It is not clear what the disabled field is for and I get this for the Basic Workflow:
screen shot 2021-05-09 at 07 22 53


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33581.

avatar sandramay0905 sandramay0905 - test_item - 9 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 9 May 2021

I have tested this item successfully on 145969b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33581.

avatar richard67 richard67 - change - 9 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 9 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33581.

avatar richard67 richard67 - change - 9 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-09 12:58:27
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 9 May 2021
avatar richard67 richard67 - merge - 9 May 2021
avatar richard67
richard67 - comment - 9 May 2021

Thanks!

avatar rjharishabh
rjharishabh - comment - 9 May 2021

Thanks everyone

Add a Comment

Login with GitHub to post a comment