? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
5 May 2021

Pull Request for Issue # .

Summary of Changes

Add removal of files removed with PR #33390 to script.php .

I do this PR here now because script.php has been recently updated so it's up to date with all other changes, only this one is missing right now, and I want it not to be forgotten when doing the next 4.0 release.

Testing Instructions

Code review:

  • The files added by this PR are the same as those deleted with PR #33390 from the sources, except of those in the installation folder.
  • They are added at the right place for alphabetical order within the section after the // 4.0 from Beta 7 to Beta 8 comment in script.php.
  • There is no PHP syntax error (missing quotes, missing comma, whatever possible).

Alternatively do a real test with updating a current 4.0-dev or latest nightly to the update package or custom URL created by Drone for this PR and checking that the files are really removed by the update.

Actual result BEFORE applying this Pull Request

Files removed with PR #33390 from the sources will not be deleted with a CMS update.

Expected result AFTER applying this Pull Request

Files removed with PR #33390 from the sources will be deleted with a CMS update.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 5 May 2021
avatar richard67 richard67 - change - 5 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 May 2021
Category Administration com_admin
avatar brianteeman brianteeman - test_item - 5 May 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 May 2021

I have tested this item successfully on 1f0daef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33555.

avatar Quy Quy - test_item - 5 May 2021 - Tested successfully
avatar Quy
Quy - comment - 5 May 2021

I have tested this item successfully on 1f0daef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33555.

avatar Quy Quy - change - 5 May 2021
Status Pending Ready to Commit
Labels Added: ?
avatar Quy
Quy - comment - 5 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33555.

avatar wilsonge wilsonge - change - 6 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-06 12:06:25
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 6 May 2021
avatar wilsonge wilsonge - merge - 6 May 2021
avatar wilsonge
wilsonge - comment - 6 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment