[#33545] - [4.0] a11y - prevent double announcement of readmore
- Closed
- 4 May 2021
- Medium
- Build: 4.0-dev
- # 33545
- Diff
- chmst:a11y-prevent-double-announcement-readmore
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Readmore has an aria-label. Additionally, the text on the button is announced by the screenreader. This results in a double announcement. This PR hides the button-text for screenreaders.
Credits: Accessibilty Team
Testing Instructions
Make Articles with Readmore. Use different variants
- Readmore with title
- Readmore without title
- Readmore with request for login
Check the sourcecode or use a screenreader or another a11y testing tool.
Actual result BEFORE applying this Pull
Expected result AFTER applying this Pull Request
The text on the Readmore button remains as before.
But the screenreader announces always the Readmore-text plus titile.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
It would be really interesting to know which testing tool and screen reader that have been used
and to just so you dont have to take my word for it. the following link has been tested with most known browsers, os and screen reader combinations.
Test link
` <a href='4567.html' aria-label='this is an aria label'>Click Here</a>`
Test results with audio
https://www.powermapper.com/tests/screen-readers/labelling/a-aria-label/
Thank you for testing! I don't hear the screenreader :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-04 15:54:20 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
|
||
This doc explains it https://www.accessibility-developer-guide.com/setup/screen-readers/nvda/#speech-viewer
PS I really want to know how the JAT thought this was a problem and what software they were using that indicated it was a problem so that we can prevent this happening again and to save you time writing code
Sorry this is not correct. The reported issue does not occur so this PR is not needed
The presence of the aria-label already ensures that it is the aria label that is announced and not the content of the link (that is the actual intended purpose of the aria-label)
Tested with Windows Narrator and NVDA which both only announce the aria-label
Tested with chrome browser which clearly shows that the only thing that is in the accessibility tree is the aria-label
(oops wrong image originally)