[#3353] - [Code Style] Fixed codestyles in the plugins folder
- Closed
- 26 May 2014
- Medium
- Build: staging
- # 3353
- Diff
- SniperSister:32-codestyle-plugins
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fixed the remaining, non BC- or template-related code style issues
We need to change back the other $_variableName instances as well for the same b/c reasons as above :/
No, they are fine since those are private properties. They can't be accessed by extending classes 
@SniperSister Can you rebase this PR and solve the conflicts?
To which branch should I rebase the PR?
Staging please.
More or less done - but I think i screwed up the commit history :(
The history doesn't concern me much. I can deal with that. But it contains also changed files which are not part of your original PR. Not sure what happend there.
What's really weird is some of those changes marked have already been made in staging (the removing of the beeze message file etc.)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-26 12:53:19 |
| Status | Closed | ⇒ | New |
| Status | New | ⇒ | Closed |
| Closed_Date | 2014-05-26 12:53:19 | ⇒ | 2014-05-26 12:55:30 |
Okay, I'll try to start a new PR
We need to change back the other $_variableName instances as well for the same b/c reasons as above :/