Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
3 May 2021

Pull Request for #33100 (comment)

Summary of Changes

Sorry, looks like one of the PRs did not get refactored as time moved on and underlying changes were being merged.

Refactor to use newly implemented getEmptyStateQuery method instead of getisEmptyState

Testing Instructions

Joomla 4 admin -> System -> Site Modules - Error Page
Apply PR
Joomla 4 admin -> System -> Site Modules - List of modules

Repeat for Joomla 4 admin -> System -> Administrator Modules

Actual result BEFORE applying this Pull Request

Red screen of death

Expected result AFTER applying this Pull Request

List of modules

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 3 May 2021
avatar PhilETaylor PhilETaylor - change - 3 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2021
Category Administration com_installer com_modules
avatar Quy Quy - test_item - 3 May 2021 - Tested successfully
avatar Quy
Quy - comment - 3 May 2021

I have tested this item successfully on 7bd8447

Thank you!!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33519.

avatar wilsonge wilsonge - test_item - 3 May 2021 - Tested successfully
avatar wilsonge
wilsonge - comment - 3 May 2021

I have tested this item successfully on 7bd8447

Works for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33519.

avatar wilsonge wilsonge - change - 3 May 2021
Status Pending Ready to Commit
avatar wilsonge wilsonge - change - 3 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-03 23:00:21
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 May 2021
avatar wilsonge wilsonge - merge - 3 May 2021
avatar wilsonge
wilsonge - comment - 3 May 2021

Thanks!

Add a Comment

Login with GitHub to post a comment