? ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
3 May 2021

Summary of Changes

Fixes the pre-upgrade check schema checker

Testing Instructions

Set upstream to have a custom update site to the Joomla 4 nightly: URL is https://update.joomla.org/core/nightlies/next_major_list.xml
Screenshot 2021-05-03 at 16 05 13

Ideally for this also install some other extensions so it's clear the data is returned for core rather than for any other core extension (as the major change in J4 is that the database fixer works for other extensions as well as core)

Actual result BEFORE applying this Pull Request

Setup the update server above with a fresh install of J4. Note that the check for the Table Database Structure shows as out of date.

Apply patch

Expected result AFTER applying this Pull Request

Table now shows successful:

Screenshot 2021-05-03 at 16 10 13

Now add a file 4.0.0-2021-05-03.sql into the following directory administrator/components/com_admin/sql/updates/mysql (just copy and paste an existing file in the directory). Check that after refreshing that that the check now again shows correctly as failed.

Documentation Changes Required

N/A

avatar wilsonge wilsonge - open - 3 May 2021
avatar wilsonge wilsonge - change - 3 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2021
Category Administration com_joomlaupdate
avatar wilsonge wilsonge - change - 3 May 2021
Title
Fix the db schema checker in 4.0
[4.0] Fix the db schema checker in 4.0
avatar wilsonge wilsonge - edited - 3 May 2021
avatar richard67 richard67 - test_item - 3 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 3 May 2021

I have tested this item successfully on f2a2e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33512.

avatar richard67 richard67 - change - 3 May 2021
The description was changed
avatar richard67 richard67 - edited - 3 May 2021
avatar alikon alikon - test_item - 3 May 2021 - Tested successfully
avatar alikon
alikon - comment - 3 May 2021

I have tested this item successfully on f2a2e65


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33512.

avatar alikon alikon - change - 3 May 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 3 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33512.

avatar Quy Quy - change - 3 May 2021
Labels Added: ?
avatar wilsonge wilsonge - close - 4 May 2021
avatar wilsonge wilsonge - merge - 4 May 2021
avatar wilsonge wilsonge - change - 4 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-04 23:44:54
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 4 May 2021

Thanks guys!

Add a Comment

Login with GitHub to post a comment