? ? ? Pending

User tests: Successful: Unsuccessful:

avatar Kostelano
Kostelano
3 May 2021

Summary of Changes

Go to Privacy -> Extension Capabilities, note that the information is displayed as a list. However, there are one-item lists that don't look very good.

BEFORE / AFTER

Screenshot_1

Screenshot_2

avatar Kostelano Kostelano - open - 3 May 2021
avatar Kostelano Kostelano - change - 3 May 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 May 2021
Category Administration
avatar YatharthVyas YatharthVyas - test_item - 3 May 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 3 May 2021

I have tested this item successfully on f193970


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33499.

avatar ChristineWk ChristineWk - test_item - 3 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 3 May 2021

I have tested this item successfully on f193970


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33499.

avatar sandramay0905 sandramay0905 - test_item - 3 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 3 May 2021

I have tested this item successfully on f193970

Ups, haven't noticed the second test.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33499.
avatar Quy
Quy - comment - 3 May 2021

Please fix language string/markup as a side-effect of this PR.

33499

avatar Quy Quy - change - 8 May 2021
Labels Added: ? ?
avatar Kostelano Kostelano - change - 8 May 2021
Labels Added: ?
Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 8 May 2021
Category Administration Administration Language & Strings
avatar Kostelano
Kostelano - comment - 8 May 2021

@Quy, thanks.

I corrected the code + made changes to the language constants, because the text after the edit "stuck together". Everything looks good now.

Screenshot_1

@YatharthVyas @ChristineWk @sandramay0905

If you have time, please retest.

avatar YatharthVyas YatharthVyas - test_item - 8 May 2021 - Tested successfully
avatar YatharthVyas
YatharthVyas - comment - 8 May 2021

I have tested this item successfully on 03b19aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33499.

avatar ChristineWk ChristineWk - test_item - 8 May 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 8 May 2021

I have tested this item successfully on 03b19aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33499.

avatar brianteeman
brianteeman - comment - 8 May 2021

Sorry this is not correct. They are lists and should remain as lists.
Changing a list item to a paragraph changes the semantic meaning

avatar brianteeman brianteeman - test_item - 8 May 2021 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 8 May 2021

I have tested this item ? unsuccessfully on 03b19aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33499.

avatar Kostelano
Kostelano - comment - 8 May 2021

Hmm. There is no point in arguing. But I see no reason to use a list in a place where the list is 1 line long.

avatar brianteeman
brianteeman - comment - 8 May 2021

semantics. For a list with one item it might not make much of a difference in semantics. Changing a list of three items to 3 paragraphs changes the semantic meaning.

avatar Kostelano Kostelano - change - 9 May 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-05-09 13:46:23
Closed_By Kostelano
Labels Added: ? ?
Removed: ?
avatar Kostelano Kostelano - close - 9 May 2021

Add a Comment

Login with GitHub to post a comment