[#33492] - [4.0] Change width and add legend in com_workflow
- Closed
- 6 May 2021
- Medium
- Build: 4.0-dev
- # 33492
- Diff
- rjharishabh:edit-workflow
User tests: Successful: Unsuccessful:
Pull Request for Issue #.
Summary of Changes
Add legend and col-md-6 class
Testing Instructions
Dashboard > Content > Workflows > Click on any workflow
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_workflow |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33492.
| Labels |
Added:
?
|
||
Previous test results are still valid since the commit which invalidated them was just code style (indent). I've restored them in the issue tracker so they are properly counted again.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33492.
No sorry, this is not quite correct.
Two times "Description" is too much. And it looks as if state and default are connected to the description, but they are attributes of the workflow.
Is it good to remove Name (en-GB) description or the other
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to comments above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33492.
@rjharishabh think about it. why do you think it is there. Was there a purpose in displaying that or was someone crazy and just decided to spit it out? When you work out the reason then you will have your answer.
@rjharishabh Now after PR #33100 has been merged, your PR here conflicts in file administrator/components/com_workflow/tmpl/workflow/edit.php. You could try to solve them, and if you would need help you could notify me and I could help, but the question is if it still needs this PR here now. Could you check and report back here? Thanks in advance.
Explaning my comment:
A fieldset is a container around fields which belong together. So users with assistive technologies are supported. In the screen above you see, that the fieldset keeps the note, which is a description, together with state and the switcher for default. This would make the user think that the description is published / unpublished or set default.
So please remove the additional fieldset.
So please remove the additional fieldset.
... and fix the merge conflict. Or if easier, replace this PR by a new one.
I will fix it
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-06 16:22:29 |
| Closed_By | ⇒ | rjharishabh | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 90ebbc8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33492.