[#33460] - [4][com_installer] update site location editable
- Closed
- 12 May 2021
- Medium
- Build: 4.0-dev
- # 33460
- Diff
- alikon:patch-130
User tests: Successful: Unsuccessful:
Pull Request for Issue #33439 .
Summary of Changes
make update site location editable
Testing Instructions
go to Extensions: Update Sites
edit an item (chnage something in the location field) and save
don't worry hitting rebuild the original one is restored
Actual result BEFORE applying this Pull Request
update site location not editable
Expected result AFTER applying this Pull Request
update site location editable
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33460.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33460.
I am not convinced yet that it was intended for this field to be editable
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33460.
I am not convinced yet that it was intended for this field to be editable
Me neither => Setting the RLDQ (Release Lead Decision Queue) label and pinging the guys of Glip for discussion.
What sense does it make to edit the location field? Won't it be overwritten with the next rebuild of update sites? Are we triggering that rebuild automatically in some cases? Or does it only happen if someone uses the button for that? In the first case, editing the field would not make much sense, would it?
The Location of update site is defined in the manifest file of the extension https://docs.joomla.org/Manifest_files#Update_servers and should not be editable (it will be updated when we rebuild update sites for example). If it is needed, we can change code so that if there is no data for extra query, the save buttons can be removed (since there is no change to save). And in that case, maybe change page title from Edit Update Site to View Update Site. At of right now, this PR should not be RTC.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33460.
| Labels |
Added:
?
|
||
What sense does it make to edit the location field?
suppose you have installed extA wich follow the j update ie have an update server link in the extension manifest
now suppose the extension developer change that link for whatever reason...and provide a new one for extA
with this pr the end user can simply change that
@alikon If an extension changes it update server, it should not ask every user to change it manually. It should be updated automatically during upgrade process (I'm a bit surprise that it is not updated automatically by Joomla while updating the extension - mean developer will have to write some script to update).
let me disagree on this
and in the hope that site admin are skilled
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-12 19:17:07 |
| Closed_By | ⇒ | alikon |
I have tested this item✅ successfully on 74f69e2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33460.