? ? Pending

User tests: Successful: Unsuccessful:

avatar rjharishabh
rjharishabh
30 Apr 2021

Pull Request for Issue #33430

Summary of Changes

remove class btn-group

Testing Instructions

Go to System - Update (Joomla) - Download and Updates tab, select the update package, click the download button. Note that the buttons on the new page are inseparable.

Actual result BEFORE applying this Pull Request

Inseparable buttons

button_before

Expected result AFTER applying this Pull Request

Separable buttons

button_after

Documentation Changes Required

None

avatar rjharishabh rjharishabh - open - 30 Apr 2021
avatar rjharishabh rjharishabh - change - 30 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Category Administration com_joomlaupdate
avatar Kostelano Kostelano - test_item - 30 Apr 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 30 Apr 2021

I have tested this item successfully on 0ba0c00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33446.

avatar Kostelano
Kostelano - comment - 30 Apr 2021

Maybe remove the LOGIN header?

avatar rjharishabh
rjharishabh - comment - 30 Apr 2021

@Kostelano I think it should be there for warning

avatar rjharishabh rjharishabh - change - 30 Apr 2021
Labels Added: ?
avatar sandramay0905 sandramay0905 - test_item - 1 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 1 May 2021

I have tested this item successfully on 2225379

@Kostelano can you please retest here too?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33446.

avatar Kostelano Kostelano - test_item - 1 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 1 May 2021

I have tested this item successfully on 2225379


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33446.

avatar richard67 richard67 - change - 1 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 1 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33446.

avatar richard67
richard67 - comment - 1 May 2021

Drone failure is not related to this PR.

avatar richard67
richard67 - comment - 1 May 2021

Restarted drone. All fine now.

avatar Quy Quy - change - 1 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-01 18:04:03
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 1 May 2021
avatar Quy Quy - merge - 1 May 2021
avatar Quy
Quy - comment - 1 May 2021

Thanks

Add a Comment

Login with GitHub to post a comment