User tests: Successful: Unsuccessful:
Pull Request for Issue #33433
Added a missing required attribute to the input.
Please enter Russian letters, for example, "ыыыыыыы" as the template name. The page will reload, there will be no error messages, but the style will not be copied either.
Page reloads without showing any error.
For Russian Characters:
ыыыыыыы
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_templates |
Labels |
Added:
?
|
Category | Administration com_templates | ⇒ | Administration com_templates Language & Strings |
Labels |
Added:
?
|
Category | Administration com_templates Language & Strings | ⇒ | Administration com_templates |
Labels |
Removed:
?
|
@Kostelano Thanks, I missed out on this edge case.
Apparently, some non-English characters bypass the required check and they are passed as an empty string to the POST request. This causes the else block of strlen> 0 to execute. I've used this condition to display an error message. The current error message doesn't specify 'English characters' so if there is a need to rephrase that, please let me know
I have tested this item
Thanks, everything is working as it should. I translated this line into russian for Joomla 3, adding the phrase "only latin letters".
translated this line into russian for Joomla 3, adding the phrase "only latin letters".
Yes I think thats the best way to address this.
I have tested this item
@Kostelano can you please retest? Issue tracker doesn't show you test anymore.
that's normal because a new commit has been made after that test
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Restarted drone. All fine now.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-01 18:23:17 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
Thank you!
Please enter Russian letters, for example, "ыыыыыыы" as the template name. The page will reload, there will be no error messages, but the style will not be copied either.
Everything is in order with the Latin letters.
I think it makes sense to implement an error message, and not just validate the field for characters / letters.