? ? Pending

User tests: Successful: Unsuccessful:

avatar YatharthVyas
YatharthVyas
30 Apr 2021

Pull Request for Issue #33433

Summary of Changes

Added a missing required attribute to the input.

Testing Instructions

  1. Joomla Admin Panel -> System
  2. Site Templates
  3. Select a template
  4. Click on the Copy Template button
  5. Submit the form without entering anything in the input box

Please enter Russian letters, for example, "ыыыыыыы" as the template name. The page will reload, there will be no error messages, but the style will not be copied either.

Actual result BEFORE applying this Pull Request

Page reloads without showing any error.

Expected result AFTER applying this Pull Request

image

For Russian Characters:

ыыыыыыы

image

Documentation Changes Required

None

avatar YatharthVyas YatharthVyas - open - 30 Apr 2021
avatar YatharthVyas YatharthVyas - change - 30 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Category Administration com_templates
avatar Kostelano
Kostelano - comment - 30 Apr 2021

Please enter Russian letters, for example, "ыыыыыыы" as the template name. The page will reload, there will be no error messages, but the style will not be copied either.

Everything is in order with the Latin letters.

I think it makes sense to implement an error message, and not just validate the field for characters / letters.

avatar YatharthVyas YatharthVyas - change - 30 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Category Administration com_templates Administration com_templates Language & Strings
avatar YatharthVyas YatharthVyas - change - 30 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Category Administration com_templates Language & Strings Administration com_templates
avatar YatharthVyas YatharthVyas - change - 30 Apr 2021
Labels Removed: ?
avatar YatharthVyas YatharthVyas - change - 30 Apr 2021
The description was changed
avatar YatharthVyas YatharthVyas - edited - 30 Apr 2021
avatar YatharthVyas
YatharthVyas - comment - 30 Apr 2021

@Kostelano Thanks, I missed out on this edge case.

Apparently, some non-English characters bypass the required check and they are passed as an empty string to the POST request. This causes the else block of strlen> 0 to execute. I've used this condition to display an error message. The current error message doesn't specify 'English characters' so if there is a need to rephrase that, please let me know

russianname1

avatar Kostelano Kostelano - test_item - 30 Apr 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 30 Apr 2021

I have tested this item successfully on 88c3c6a

Thanks, everything is working as it should. I translated this line into russian for Joomla 3, adding the phrase "only latin letters".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33444.

avatar brianteeman
brianteeman - comment - 30 Apr 2021

translated this line into russian for Joomla 3, adding the phrase "only latin letters".

Yes I think thats the best way to address this.

avatar sandramay0905 sandramay0905 - test_item - 1 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 1 May 2021

I have tested this item successfully on 8d6d1d7

@Kostelano can you please retest? Issue tracker doesn't show you test anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33444.

avatar alikon
alikon - comment - 1 May 2021

that's normal because a new commit has been made after that test

avatar Kostelano Kostelano - test_item - 1 May 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 1 May 2021

I have tested this item successfully on 8d6d1d7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33444.

avatar alikon alikon - change - 1 May 2021
Status Pending Ready to Commit
avatar alikon
alikon - comment - 1 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33444.

avatar sandramay0905
sandramay0905 - comment - 1 May 2021

that's normal because a new commit has been made after that test

Thanks @alikon. I asked cause if i test i don't look later if it don't count cause of new commit so i'm fine if someone inform me about retesting.

avatar richard67
richard67 - comment - 1 May 2021

Restarted drone. All fine now.

avatar Quy Quy - change - 1 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-01 18:23:17
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 1 May 2021
avatar Quy Quy - merge - 1 May 2021
avatar Quy
Quy - comment - 1 May 2021

Thank you!

Add a Comment

Login with GitHub to post a comment