Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33442] - [4.0] Private Messages: Add legend in Configuration Form

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar YatharthVyas
YatharthVyas
30 Apr 2021

Pull Request for Issue #33431

Summary of Changes

  1. Added <fieldset class="options-form"> and <legend> to the form as suggested in the issue.
  2. Removed a redundant language constant COM_MESSAGES_CONFIGURATION. This wasn't used in any file throughout the Joomla-CMS repository. (I ran a global search using two unique IDEs)
  3. Added a new constant COM_MESSAGES_CONFIGURATION_FORM="My Settings" for the Form's Legend. (Read: #33431 (comment))

Note: As I have added a new constant, it must be added in other languages during translations

Testing Instructions

  1. Joomla Admin Panel -> Private Messages (Top Right in Toolbar)
  2. Click on My Settings

A Legend can be seen after applying the patch

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

None

avatar YatharthVyas YatharthVyas - open - 30 Apr 2021
avatar YatharthVyas YatharthVyas - change - 30 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Category ⇒ Administration com_messages Language & Strings
avatar Kostelano Kostelano - test_item - 30 Apr 2021 - Tested successfully
avatar Kostelano
Kostelano - comment - 30 Apr 2021

I have tested this item ✅ successfully on 8a7cfa9

Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33442.

avatar YatharthVyas YatharthVyas - change - 30 Apr 2021
The description was changed
avatar YatharthVyas YatharthVyas - edited - 30 Apr 2021
avatar alikon alikon - test_item - 1 May 2021 - Tested successfully
avatar alikon
alikon - comment - 1 May 2021

I have tested this item ✅ successfully on 8a7cfa9

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33442.

avatar alikon alikon - change - 1 May 2021
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 1 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33442.

avatar alikon
alikon - comment - 1 May 2021

drone failure unrelated to this pr

avatar YatharthVyas YatharthVyas - change - 1 May 2021
Labels Added: ? ? ?
avatar richard67 richard67 - alter_testresult - 1 May 2021 - Kostelano: Tested successfully
avatar richard67 richard67 - alter_testresult - 1 May 2021 - alikon: Tested successfully
avatar richard67
richard67 - comment - 1 May 2021

I've restored the previous test results since the commit which has invalidated them was just a rename of the language string constant, of which I've verified by code review that ot has been done right.

avatar Quy Quy - change - 1 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-01 18:50:02
Closed_By ⇒ Quy
Labels Added: ?
Removed: ?
avatar Quy Quy - close - 1 May 2021
avatar Quy Quy - merge - 1 May 2021
avatar Quy
Quy - comment - 1 May 2021

Thank you!

Add a Comment

Login with GitHub to post a comment