?
avatar Kostelano
Kostelano
30 Apr 2021

Steps to reproduce the issue

Go to System - Update sites, select any site, click on the Actions - Edit buttons. You will be taken to a new page, but I was unable to make changes to the update site - the fields are not available.

Perhaps the restriction applies only to sites from the Joomla package.

Unfortunately, I don't have a Joomla 4 extension handy that has an update site out of the box to test the behavior there.

Screenshot_4

avatar Kostelano Kostelano - open - 30 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Apr 2021
avatar Kostelano Kostelano - change - 30 Apr 2021
The description was changed
avatar Kostelano Kostelano - edited - 30 Apr 2021
avatar brianteeman
brianteeman - comment - 30 Apr 2021

Perhaps the restriction applies only to sites from the Joomla package.

correct

avatar Bakual
Bakual - comment - 30 Apr 2021

Not correct. The same happens with my own component (you can try yourself with https://github.com/Bakual/SermonSpeaker/releases/tag/6.0.0-beta2).

Looking at the code, the name, type and location fields are declared as readonly:

<field
name="name"
type="text"
label="COM_INSTALLER_FIELD_NAME_LABEL"
disabled="true"
/>
<field
name="type"
type="text"
label="COM_INSTALLER_FIELD_TYPE_LABEL"
disabled="true"
/>
<field
name="location"
type="text"
label="COM_INSTALLER_FIELD_TYPE_LOCATION"
disabled="true"
/>

So I assume you are only meant to edit the additional extra_query field (if used by the extension).

Maybe @roland-d can say more?

avatar brianteeman
brianteeman - comment - 30 Apr 2021

image

avatar Kostelano
Kostelano - comment - 30 Apr 2021

Even if the restriction for the sites of the Joomla package is implemented, then it is necessary to somehow indicate it clearly for the user. It is possible to use the lock icon specifically for these update sites. Similar to how it is implemented in Extension Management.

Screenshot_2

avatar roland-d
roland-d - comment - 30 Apr 2021

The edit screen is indeed for managing the download key for that extension. There should not be a need for end-users to modify the update server details.

Even if the restriction for the sites of the Joomla package is implemented, then it is necessary to somehow indicate it clearly for the user.

I am not sure what you are asking here but the lock icon has a completely different goal. When you have an extension and a download key you will go to the edit screen on an update site, there is no other reason to go there.

avatar Bakual
Bakual - comment - 30 Apr 2021

It's just pretty pointless to offer editing an updatesite where you can't edit anything:
image

So maybe only offer that possibility for those extensions which have a download key? Would make a better UX I guess.

avatar Kostelano
Kostelano - comment - 30 Apr 2021

@roland-d Now (when you explained) I understand WHAT this button specifically implies. The point is that ordinary users of Joomla do not run around the forums with the question "something does not work" for the sake of such a simple thing :). If editing is intended only for entering a key, then it makes sense to make the button inactive for extensions that do not use an access key. Or, alternatively, rename the button to something like "Edit Key". Anyway, it seems to me that the current state of the page / function needs a little work.

avatar roland-d
roland-d - comment - 30 Apr 2021

Feel free to make the changes you wish.

avatar alikon alikon - close - 1 May 2021
avatar alikon
alikon - comment - 1 May 2021

iirc in the orginal gsoc project it was editable
please test #33460

avatar alikon alikon - change - 1 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-01 06:27:27
Closed_By alikon

Add a Comment

Login with GitHub to post a comment