Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#33436] - [4.0] Move form text below field

? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
30 Apr 2021

Summary of Changes

For consistency, move form text below field and use form-text class.

Testing Instructions

Go to System > Site Templates
Click Cassiopeia Details and Files.
Click Copy Template button.

Actual result BEFORE applying this Pull Request

copy-template-before

Expected result AFTER applying this Pull Request

copy-template-after

avatar Quy Quy - open - 30 Apr 2021
avatar Quy Quy - change - 30 Apr 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Category ⇒ Administration com_templates
avatar brianteeman
brianteeman - comment - 30 Apr 2021

For consistency please put the text-muted class back

avatar Quy
Quy - comment - 30 Apr 2021

form-text sets color and font-size so no need to use text-muted.

avatar Quy
Quy - comment - 30 Apr 2021

I will be doing a separate PR to remove text-muted from form-text that has this class.

avatar brianteeman
brianteeman - comment - 30 Apr 2021

image

avatar Quy
Quy - comment - 30 Apr 2021

I understand but why add another class to override the color. Might as well override .form-text.

avatar Quy
Quy - comment - 30 Apr 2021

Plus you can barely tell the difference without text-muted.

avatar Quy
Quy - comment - 30 Apr 2021

From Bootstrap 5 Migration page.

.form-text no longer sets display, but does set color and font-size. So instead of <small class="form-text text-muted"> you should now use <div class="form-text">.
avatar sandramay0905 sandramay0905 - test_item - 1 May 2021 - Tested successfully
avatar sandramay0905
sandramay0905 - comment - 1 May 2021

I have tested this item ✅ successfully on e506f27

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33436.

avatar richard67 richard67 - test_item - 1 May 2021 - Tested successfully
avatar richard67
richard67 - comment - 1 May 2021

I have tested this item ✅ successfully on e506f27

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33436.

avatar richard67 richard67 - change - 1 May 2021
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 1 May 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33436.

avatar richard67
richard67 - comment - 1 May 2021

I will be doing a separate PR to remove text-muted from form-text that has this class.

@Quy Trusting this, the PR is ok for me. But for consistency that really should not be forgotten.

avatar richard67 richard67 - change - 1 May 2021
Labels Added: ? ?
avatar chmst chmst - change - 2 May 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-05-02 19:53:04
Closed_By ⇒ chmst
Labels Added: ?
Removed: ?
avatar chmst chmst - close - 2 May 2021
avatar chmst chmst - merge - 2 May 2021

Add a Comment

Login with GitHub to post a comment