No Code Attached Yet bug
avatar Kostelano
Kostelano
30 Apr 2021

Steps to reproduce the issue

Go to System - Update sites, select any site and click the Actions button. I would prefer that the icons are not duplicated. Probably the trash icon would be more appropriate here.

Screenshot_1

avatar Kostelano Kostelano - open - 30 Apr 2021
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Apr 2021
avatar YatharthVyas
YatharthVyas - comment - 1 May 2021

I agree that both the icons appear visually similar but these icons have different classes:

  • icon-unpublish for disable

image

  • icon-delete for delete

image

If we were to change the delete icon to icon-trash, It might give the users a false feeling of Trashing the item (similar to articles) and that hope that they can recover this trashed item later which is not the case with delete. In my opinion, this would not be in the best interest of preserving the consistency of icons across different modules.

image

avatar PhilETaylor
PhilETaylor - comment - 1 May 2021

In joomla trash and delete should and do mean different things

Trash = move to trash status which can be changed back to another status

Delete = gone forever, deleted

avatar drmenzelit
drmenzelit - comment - 2 May 2021

icon-unpublished and icon-delete (and probably others too) are both mapped to $fa-var-times in \system\scss\_icomoon.scss. A specific class icon-disable will be helpful, for example as fas fa-ban

avatar Kostelano Kostelano - change - 4 May 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-05-04 09:54:30
Closed_By Kostelano
avatar Kostelano Kostelano - close - 4 May 2021
avatar Kostelano
Kostelano - comment - 4 May 2021

PR #33515

avatar drmenzelit drmenzelit - change - 30 Oct 2023
Status Closed New
Closed_Date 2021-05-04 09:54:30
Closed_By Kostelano
Labels Added: No Code Attached Yet
Removed: ?
avatar drmenzelit drmenzelit - reopen - 30 Oct 2023
avatar Hackwar Hackwar - change - 27 Mar 2024
Labels Added: bug
avatar Hackwar Hackwar - labeled - 27 Mar 2024

Add a Comment

Login with GitHub to post a comment