I've not implemented code to handle the case when $this->app->login() fails (when it returns false). The previous code also didn't handle it. If that also needs to be altered it could be done with another PR.

Imho it just doesn't matter at all. The event is fired in https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/cms.php#L587 and the response isn't stored.

So we can return whatever we want. I think returning true or false may help understand the code in that you know it triggered or not. But that's all. There is no actual function to it.

I think returning true or false may help understand the code in that you know it triggered or not.

I disagree. If it's not stored then there's no point in returning a boolean. IMHO it even makes it harder to understand, returning false (or true) makes you think the returned value would have an effect.

There is no actual function to it.

True, it has no effect (in this case).

PR is fine with me.

Error handling is done by the actual cookie plugin and the application. I don't think we need anything here. Cookie login should be as invisible as possible anyway

Care to do a tracker?

Care to do a tracker?

Yes, no problem. Tracker: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33498&start=0

Thanks. And test is fine

Thanks, guys!