? ? Pending

User tests: Successful: Unsuccessful:

avatar himanshu007-creator
himanshu007-creator
30 Apr 2021

Pull Request for Issue #33379

Summary of Changes

Remove migration script for blog layout as now the function is no longer needed.

Testing Instructions

Install J3.10 and make some blogs with entries in num_columns. Update to J4.0
in J4.0, blog must have same same columns as there were in J3.10

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

none

avatar himanshu007-creator himanshu007-creator - open - 30 Apr 2021
avatar himanshu007-creator himanshu007-creator - change - 30 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Apr 2021
Category Administration com_admin
avatar himanshu007-creator himanshu007-creator - change - 30 Apr 2021
Labels Added: ?
avatar chmst
chmst - comment - 30 Apr 2021

@Harmageddon could you please have a look here? As we now have a param num_columns, the script is no longer needed.

avatar himanshu007-creator himanshu007-creator - change - 30 Apr 2021
The description was changed
avatar himanshu007-creator himanshu007-creator - edited - 30 Apr 2021
avatar richard67
richard67 - comment - 30 Apr 2021

@himanshu007-creator Please change the title of this PR to something more meaningful about what the changes are good for.

avatar himanshu007-creator himanshu007-creator - change - 30 Apr 2021
Title
Update script.php
[4.0] Remove Migration Script
avatar himanshu007-creator himanshu007-creator - edited - 30 Apr 2021
avatar joomdonation
joomdonation - comment - 1 May 2021

Please remove some un-used use statements at the top of file:

use Joomla\CMS\Component\ComponentHelper;
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Config\Administrator\Model\ComponentModel;
avatar joomdonation
joomdonation - comment - 1 May 2021

@chmst In the original PR, some parameters were added as global class classes https://github.com/joomla/joomla-cms/pull/31570/files#diff-250b59d27f418e931b052803c0a6089439df3f1ada6db18096ec9f9e5edb095cR717-R731 .Do we need to keep these parameters or it should be reverted?

avatar Harmageddon
Harmageddon - comment - 1 May 2021

I don't have time today, but am going to have a look at this tomorrow. On a first glance: Looks good to me, thanks for taking care of this one!

avatar Harmageddon Harmageddon - test_item - 2 May 2021 - Tested successfully
avatar Harmageddon
Harmageddon - comment - 2 May 2021

I have tested this item successfully on 182ceb1

Tested upgrade from 3.9.26 (with column settings) and from 4.0-beta8 (with CSS classes). Nothing seems to break. PR does a clean removal of the upgrade functionality in #31570.

@joomdonation I'd keep those global parameters, as there may be use cases for setting CSS classes globally, and I don't see any disadvantages.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

avatar richard67
richard67 - comment - 2 May 2021

Tested upgrade from 3.9.26 (with column settings) ...

@Harmageddon Did you do that directly from 3.9.26 to 4 and not with an intermediate 3.10? That might work when using "Upload & Update" but is not officially supported. It's ok for the test here, but I thought I should spread the information that it's not the official way.

(Sorry I've first mentioned the wrong person here, so @himanshu007-creator please ignore the notification.)

avatar Harmageddon
Harmageddon - comment - 2 May 2021

@Harmageddon Did you do that directly from 3.9.26 to 4 and not with an intermediate 3.10? That might work when using "Upload & Update" but is not officially supported. It's ok for the test here, but I thought I should spread the information that it's not the official way.

Ah yes, you're perfectly right there. I couldn't find my old backup I used for upgrade tests, that was probably on 3.10, and just picked a new download package. Sorry for that, still it worked! :-D

avatar ChristineWk
ChristineWk - comment - 4 May 2021

Had already successfully used this procedure J 3.10 to J 4.0 a few times ... and at that time in the course of #31570 etc.
As described here: https://www.joomla.org/announcements/release-news/5833-joomla- 4-0-0-beta7-and-joomla-3-10-alpha5.html
Unfortunately it doesn't work at the moment. Success was: Error 500 etc.

Backup today of my J 3.10 imported again.
The current status is: Version of the database schema (in #__schemas): 3.10.0-2020-08-10
Update version (in #__extensions): 3.10.0-alpha6-dev
Sorry about that.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

avatar joomdonation joomdonation - test_item - 7 May 2021 - Tested successfully
avatar joomdonation
joomdonation - comment - 7 May 2021

I have tested this item successfully on 182ceb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

avatar richard67 richard67 - change - 7 May 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 7 May 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33428.

avatar Quy Quy - change - 7 May 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-05-07 17:09:45
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 7 May 2021
avatar Quy Quy - merge - 7 May 2021
avatar Quy
Quy - comment - 7 May 2021

Thank you!

Add a Comment

Login with GitHub to post a comment