User tests: Successful: Unsuccessful:
Pull Request for Issue #33379
Remove migration script for blog layout as now the function is no longer needed.
Install J3.10 and make some blogs with entries in num_columns. Update to J4.0
in J4.0, blog must have same same columns as there were in J3.10
none
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin |
Labels |
Added:
?
|
@himanshu007-creator Please change the title of this PR to something more meaningful about what the changes are good for.
Title |
|
Please remove some un-used use statements at the top of file:
use Joomla\CMS\Component\ComponentHelper;
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Config\Administrator\Model\ComponentModel;
@chmst In the original PR, some parameters were added as global class classes https://github.com/joomla/joomla-cms/pull/31570/files#diff-250b59d27f418e931b052803c0a6089439df3f1ada6db18096ec9f9e5edb095cR717-R731 .Do we need to keep these parameters or it should be reverted?
I don't have time today, but am going to have a look at this tomorrow. On a first glance: Looks good to me, thanks for taking care of this one!
I have tested this item
Tested upgrade from 3.9.26 (with column settings) and from 4.0-beta8 (with CSS classes). Nothing seems to break. PR does a clean removal of the upgrade functionality in #31570.
@joomdonation I'd keep those global parameters, as there may be use cases for setting CSS classes globally, and I don't see any disadvantages.
Tested upgrade from 3.9.26 (with column settings) ...
@Harmageddon Did you do that directly from 3.9.26 to 4 and not with an intermediate 3.10? That might work when using "Upload & Update" but is not officially supported. It's ok for the test here, but I thought I should spread the information that it's not the official way.
(Sorry I've first mentioned the wrong person here, so @himanshu007-creator please ignore the notification.)
@Harmageddon Did you do that directly from 3.9.26 to 4 and not with an intermediate 3.10? That might work when using "Upload & Update" but is not officially supported. It's ok for the test here, but I thought I should spread the information that it's not the official way.
Ah yes, you're perfectly right there. I couldn't find my old backup I used for upgrade tests, that was probably on 3.10, and just picked a new download package. Sorry for that, still it worked! :-D
Had already successfully used this procedure J 3.10 to J 4.0 a few times ... and at that time in the course of #31570 etc.
As described here: https://www.joomla.org/announcements/release-news/5833-joomla- 4-0-0-beta7-and-joomla-3-10-alpha5.html
Unfortunately it doesn't work at the moment. Success was: Error 500 etc.
Backup today of my J 3.10 imported again.
The current status is: Version of the database schema (in #__schemas): 3.10.0-2020-08-10
Update version (in #__extensions): 3.10.0-alpha6-dev
Sorry about that.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-07 17:09:45 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
Thank you!
@Harmageddon could you please have a look here? As we now have a param num_columns, the script is no longer needed.