[#33414] - [4] When item doesn't exist, show specific message
- Fixed in Code Base
- 30 Apr 2021
- Medium
- Build: 4.0-dev
- # 33414
- Diff
- PhilETaylor:langwhennoitem
User tests: Successful: Unsuccessful:
Closes #33410
Summary of Changes
This PR makes two changes.
-
Correctly outputs a specific error message if an item cannot be loaded from the db - whereas presently that message is missing (only a trailing period displays currently)
-
If the above message is being displayed, then dont also confuse a user and tell them they dont have permission to that use the link. Its not correct. That message is raised in the display controller way after the first message in the models. There was a previous error before that, in the model/db that is more important (one example is the message above, saying the row doesn't exist, but other messages could exceptions "Table has multiple primary keys specified", "No table keys defined", "Missing field in database", or the
$resultcould have been modified by plugins using theonTableAfterLoadtrigger - and so telling the user after one of these more serious messages, that they "are not permitted to use that link directly" is actually not quite correct. The first message is more important.
Testing Instructions
Do some things that create audit log in User Action Logs
Lets say, create a User Note with title "myNoteTitle", save it, trash it, remove it from the trash.
Then go to Home Dashboard or Users -> User Action Log
see:
User admin added new user note myNoteTitle
click on "myNoteTitle" hyperlink
Other Example URLS of things you can try
http://127.0.0.1:4444/administrator/index.php?option=com_content&task=article.edit&id=9999999999999
http://127.0.0.1:4444/administrator/index.php?option=com_users&task=user.edit&id=9999999999999
http://127.0.0.1:4444/administrator/index.php?option=com_users&task=note.edit&id=9999999999999
http://127.0.0.1:4444/administrator/index.php?option=com_banners&task=banner.edit&id=9999999999
http://127.0.0.1:4444/administrator/index.php?option=com_fields&task=field.edit&id=9999999999999&context=com_users.user
Actual result BEFORE applying this Pull Request
A message telling me I dont have permission to use that link. But note the missing REASON on the first line, before the trailing period.
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | New |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings Libraries | ⇒ | Administration com_banners com_categories com_contact com_content com_fields com_finder com_installer com_languages com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_users com_workflow Language & Strings Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33414.
| Status | New | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33414.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 11:08:26 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 503b35e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33414.