? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
29 Apr 2021

Closes #33289

Summary of Changes

Only show versions toolbar button if the article has been saved at least once

Testing Instructions

Install Joomla 4
Trash all your Content Categories (Including the default uncategorised), empty the trash
Attempt to create a new article.

Actual result BEFORE applying this Pull Request

An error has occurred.
    0 Joomla\CMS\Toolbar\Toolbar::versions(): Argument #2 ($itemId) must be of type int, null given, called in /application/administrator/components/com_content/src/View/Article/HtmlView.php on line 209 

Screenshot 2021-04-24 at 20 21 09

Expected result AFTER applying this Pull Request

You get to the Article create screen and you can save, which creates the category on the fly on save.

Documentation Changes Required

none

avatar PhilETaylor PhilETaylor - open - 29 Apr 2021
avatar PhilETaylor PhilETaylor - change - 29 Apr 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Apr 2021
Category Administration com_content
avatar Quy Quy - test_item - 29 Apr 2021 - Tested successfully
avatar Quy
Quy - comment - 29 Apr 2021

I have tested this item successfully on beb3d62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33412.

avatar richard67 richard67 - test_item - 29 Apr 2021 - Tested successfully
avatar richard67
richard67 - comment - 29 Apr 2021

I have tested this item successfully on beb3d62


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33412.

avatar richard67 richard67 - change - 29 Apr 2021
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 29 Apr 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33412.

avatar rdeutz rdeutz - change - 30 Apr 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-04-30 11:05:03
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 30 Apr 2021
avatar rdeutz rdeutz - merge - 30 Apr 2021

Add a Comment

Login with GitHub to post a comment