If we're fixing this method can we also fix the method signature. There's two params passed in in JApplicationCMS :P

Good catch!

var_dumps described on the tracker show the expected results afterwards. Nice one!

Thanks George!

It's true that it is false to return false and it should indeed return true
My fault, by the way....

Just wondering: Did it have any impact somewhere? How did you notice?

It's true that it is false to return false and it should indeed return true

Hahaha

With Twentronix Shortcuts I assign a keyboard shortcut to logout and if it's successful refresh the page. This didn't happen because $app->logout() returned false because of the return false of the "System - Remember Me" plugin (go figure). In my case it was a small issue, it could have a more serious impact for other code though. For me it was only a page refresh which relied on it.

Thanks, merged

Wow that's quick, thank you!

+1

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Mar 20, 2014 5:18 PM, "Jurian Even" notifications@github.com wrote:

Wow that's quick, thank you!

—
Reply to this email directly or view it on GitHub#3341 (comment)
.