[#33409] - [4] Silently return early if this method has already been called for the given selector
- Closed
- 15 Aug 2021
- Medium
- Build: 4.0-dev
- # 33409
- Diff
- PhilETaylor:startTabSet
User tests: Successful: Unsuccessful:
Pull Request for Issue #33396 replacement for #33397
Summary of Changes
Reemploying the same tactic that the startAccordion method uses to return early and ignore the fact that the method has been called incorrectly, with the same selector, twice by a developer.
Prevents outputting a PHP error message.
Please read the background here #33397 (comment)
For element ID's a safe strategy is to use a pattern like company-product-specifier which should guarantee uniqueness
Testing Instructions
add the code below somewhere on a page you are looking at, refresh and see the error.
\Joomla\CMS\HTML\Helpers\Bootstrap::startTabSet('asd', []);
\Joomla\CMS\HTML\Helpers\Bootstrap::startTabSet('asd', []);Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
The page loads without a PHP error, albeit the developer still needs to fix their code as the second call to startTabSet doesn't actually do anything, but silently returns.
This is by design, because of the history explained in the background here #33397 (comment)
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Not tested by original reporting @BrainforgeUK and no other interest so closing this now.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-15 12:18:29 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on c7d4c1f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33409.