[#33406] - [4] Fix trash menu items displaying logic
- Fixed in Code Base
- 30 Apr 2021
- Medium
- Build: 4.0-dev
- # 33406
- Diff
- PhilETaylor:fixtrashbutton
User tests: Successful: Unsuccessful:
Summary of Changes
Another bug found while developing Empty States :) One a security bug.
These bugs are in Languages, Newsfeeds, Tags and Notes.
The bug is that the code below makes no sense. What its TRYING to do is only show the Trash button (in the Actions dropdown menu) when the filter for the published dropdown is NOT trashed.
But what it ACTUALLY is doing (by mistake) is making it IMPOSSIBLE to Trash items IF you have a filter set (Select Published from the Status filter for example)
if (!$this->state->get('filter.published') == -2)An example test case showing the difference in the code is here https://3v4l.org/XTPkK
That is resolved in this PR
Testing Instructions
- Login to Joomla 4 Admin
- Navigate to Components Tags
- Create a Tag and set it published
- Select the tag from the list of tags
- Click Actions - NOTE THERE IS A TRASH BUTTON (Dont click it)
- Click Filter Options
- Select PUBLISHED in the STATUS dropdown filter
- Select the tag from the list of tags
- Click Actions - NOTE THERE IS A NOT TRASH BUTTON (This is the bug, you should be able to trash this tag here)
- Apply PR
- Click Actions - NOTE THERE IS NOW A TRASH BUTTON (This is the fixed bug)
Actual result BEFORE applying this Pull Request
| Component | Trash Button Bug |
|---|---|
| Languages | Has Trash Button Bug |
| Newsfeeds | Has Trash Button Bug |
| Tags | Has Trash Button Bug |
| User Notes | Has Trash Button Bug |
Expected result AFTER applying this Pull Request
| Component | Trash Button Bug |
|---|---|
| ALL * | No Trash Button Bug |
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_languages com_newsfeeds com_tags com_users |
| Labels |
Added:
?
|
||
| Category | Administration com_banners com_contact com_languages com_newsfeeds com_tags com_users | ⇒ | Administration com_contact com_languages com_newsfeeds com_tags com_users |
| Category | Administration com_contact com_languages com_newsfeeds com_tags com_users | ⇒ | Administration com_languages com_newsfeeds com_tags com_users |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33406.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33406.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33406.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-04-30 10:10:22 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
updated code and description of the PR